105 lines
4.3 KiB
Markdown
105 lines
4.3 KiB
Markdown
# QA Notes – checking & polishing Fira Code for Google Fonts
|
||
|
||
- [ ] autohint static TTFs
|
||
|
||
## Checks to resolve
|
||
|
||
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Variable font weight coordinates must be multiples of 100.</summary>
|
||
|
||
* [com.google.fonts/check/varfont_weight_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_weight_instances)
|
||
* 🔥 **FAIL** Found an variable font instance with 'wght'=450.0. This should instead be a multiple of 100.
|
||
|
||
</details>
|
||
|
||
- (fontmake also started to fail, as "Retina" instance was given a custom param of `weightClass: 900`)
|
||
|
||
- [x] uncheck "Retina" instance as `is active` instance
|
||
- [ ] file issue with FontBakery to ask Dave/Marc about this `450` weight "Retina" instance
|
||
|
||
----------------------------
|
||
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
|
||
|
||
* [com.google.fonts/check/family/win_ascent_and_descent](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/family/win_ascent_and_descent)
|
||
* 🔥 **FAIL** OS/2.usWinAscent value should be equal or greater than 1050, but got 935 instead [code: ascent]
|
||
* 🔥 **FAIL** OS/2.usWinDescent value should be equal or greater than 500, but got 265 instead [code: descent]
|
||
|
||
</details>
|
||
|
||
- [ ] run script to correct vertical metrics, recheck
|
||
|
||
|
||
----------------------------
|
||
|
||
<details>
|
||
<summary><b>[119] FiraCode-Light.ttf</b></summary>
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Checking file is named canonically.</summary>
|
||
|
||
* [com.google.fonts/check/canonical_filename](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/canonical_filename)
|
||
* 🔥 **FAIL** This is a variable font, but it is using a naming scheme typical of a static font.
|
||
* 🔥 **FAIL** Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF
|
||
|
||
</details>
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWeightClass.</summary>
|
||
|
||
* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass)
|
||
* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
|
||
|
||
</details>
|
||
|
||
|
||
======================================================================================
|
||
|
||
## Waiting on others
|
||
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Copyright notices match canonical pattern in fonts</summary>
|
||
|
||
* [com.google.fonts/check/font_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/font_copyright)
|
||
* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
|
||
But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
|
||
|
||
</details>
|
||
|
||
- additionally, it's unclear how the original copyright on Fira Mono & Fira Code should best be integrated to credit all designers involved
|
||
|
||
- [x] file issue on fontbakery (https://github.com/googlefonts/fontbakery/issues/2419)
|
||
- [ ] confirm that current approach is fine (https://github.com/google/fonts/issues/1460#issuecomment-476713822)
|
||
|
||
----------------------------
|
||
|
||
======================================================================================
|
||
|
||
## Edits and corrected FontBakery checks
|
||
|
||
|
||
|
||
<details>
|
||
<summary>⚠ <b>WARN:</b> Stricter unitsPerEm criteria for Google Fonts. </summary>
|
||
|
||
* [com.google.fonts/check/unitsperem_strict](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/unitsperem_strict)
|
||
* ⚠ **WARN** Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
|
||
|
||
</details>
|
||
|
||
- [x] scale UPM to 2000
|
||
|
||
----------------------------
|
||
|
||
<details>
|
||
<summary>🔥 <b>FAIL:</b> Are there non-ASCII characters in ASCII-only NAME table entries?</summary>
|
||
|
||
* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries)
|
||
* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.
|
||
* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2015 by Nikita Prokopov''
|
||
|
||
</details>
|
||
|
||
- [x] remove © symbol
|
||
|
||
---------------------------- |