CodeMirror/FiraCode
1
0
Fork 0
mirror of synced 2024-05-21 21:13:28 +12:00
Code Issues Projects Releases Wiki Activity

build and check with copyright updates

Browse source
This commit is contained in:
Stephen Nixon 2019-03-26 12:52:01 -04:00
parent 19157cbea3
commit 7919f1e099
9 changed files with 80 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
FiraCode.glyphs
View file

@ -59,7 +59,7 @@ code = "Alpha\012Epsilon\012Eta\012Iota\012Omicron\012Upsilon\012Omega\012Alpha\
name = GreekUCcalt;
}
);
copyright = "Copyright © 2015 by Nikita Prokopov";
copyright = "Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)";
customParameters = (
{
name = openTypeNameLicenseURL;
@ -130,7 +130,7 @@ value = (
}
);
date = "2018-09-30 15:05:11 +0000";
designer = "Nikita Prokopov";
designer = "Carrois Corporate, Edenspiekermann AG, Nikita Prokopov";
designerURL = "http://tonsky.me";
familyName = "Fira Code";
featurePrefixes = (
@ -284,7 +284,7 @@ verticalStems = (
);
weight = Light;
weightValue = 62;
widthValue = 99.99999;
widthValue = 99;
xHeight = 1050;
},
{
@ -341,7 +341,6 @@ verticalStems = (
);
weight = Bold;
weightValue = 158;
widthValue = 100;
xHeight = 1062;
}
);
@ -107346,7 +107345,7 @@ name = Bold;
weightClass = Bold;
}
);
manufacturer = "Nikita Prokopov";
manufacturer = "Carrois Corporate, Edenspiekermann AG, Nikita Prokopov";
manufacturerURL = "http://tonsky.me";
unitsPerEm = 2000;
userData = {

BIN
distr/ttf/FiraCode-Bold.ttf
View file

Binary file not shown.

BIN
distr/ttf/FiraCode-Light.ttf
View file

Binary file not shown.

BIN
distr/ttf/FiraCode-Medium.ttf
View file

Binary file not shown.

BIN
distr/ttf/FiraCode-Regular.ttf
View file

Binary file not shown.

BIN
distr/ttf/FiraCode-Retina.ttf
View file

Binary file not shown.

BIN
distr/variable_ttf/FiraCode-VF.ttf
View file

Binary file not shown.

59
googlefonts-qa/checks/FiraCode-Light.checks.md
View file

@ -235,13 +235,6 @@ Fontbakery version: 0.7.0
* 🔥 **FAIL** This is a variable font, but it is using a naming scheme typical of a static font.
* 🔥 **FAIL** Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF
</details>
<details>
<summary>🔥 <b>FAIL:</b> Substitute copyright, registered and trademark symbols in name table entries.</summary>
* [com.google.fonts/check/name/unwanted_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/unwanted_chars)
* 🔥 **FAIL** NAMEID #0 contains symbol that should be replaced by '(c)'.
</details>
<details>
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWeightClass.</summary>
@ -249,21 +242,13 @@ Fontbakery version: 0.7.0
* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass)
* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
</details>
<details>
<summary>🔥 <b>FAIL:</b> Are there non-ASCII characters in ASCII-only NAME table entries?</summary>
* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries)
* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.
* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright &#169; 2015 by Nikita Prokopov''
</details>
<details>
<summary>🔥 <b>FAIL:</b> Copyright notices match canonical pattern in METADATA.pb</summary>
* [com.google.fonts/check/metadata/valid_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/valid_copyright)
* 🔥 **FAIL** METADATA.pb: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2015 by Nikita Prokopov'
But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
</details>
<details>
@ -271,7 +256,7 @@ But instead we have got: 'Copyright 2015 by Nikita Prokopov'
* [com.google.fonts/check/font_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/font_copyright)
* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright © 2015 by Nikita Prokopov'
But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
</details>
<details>
@ -280,13 +265,6 @@ But instead we have got: 'Copyright © 2015 by Nikita Prokopov'
* [com.google.fonts/check/metadata/os2_weightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/os2_weightclass)
* 🔥 **FAIL** OS/2 usWeightClass (400:"Regular") does not match weight specified at METADATA.pb (300:"Light").
</details>
<details>
<summary>🔥 <b>FAIL:</b> Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?</summary>
* [com.google.fonts/check/metadata/nameid/copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/nameid/copyright)
* 🔥 **FAIL** Copyright field for this font on METADATA.pb ('Copyright 2015 by Nikita Prokopov') differs from a copyright notice entry on the name table: 'Copyright (c) 2015 by Nikita Prokopov'
</details>
<details>
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
@ -466,9 +444,9 @@ But instead we have got: 'Copyright © 2015 by Nikita Prokopov'
| | FiraCode-Light.ttf |
|:--- | ---:|
| Dehinted Size | 237.7kb |
| Hinted Size | 235.8kb |
| Increase | -1916 bytes |
| Dehinted Size | 238.0kb |
| Hinted Size | 236.1kb |
| Increase | -1996 bytes |
| Change | -0.8 % |
@ -516,7 +494,7 @@ The version string must ideally include a git commit hash and either a 'dev' or
<summary>ℹ <b>INFO:</b> Font contains all required tables?</summary>
* [com.google.fonts/check/required_tables](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/required_tables)
* ℹ **INFO** This font contains the following optional tables [GSUB, loca, DSIG, prep, gasp, GPOS]
* ℹ **INFO** This font contains the following optional tables [GPOS, gasp, DSIG, loca, GSUB, prep]
* 🍞 **PASS** Font contains all required tables.
</details>
@ -526,6 +504,13 @@ The version string must ideally include a git commit hash and either a 'dev' or
* [com.google.fonts/check/fstype](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/fstype)
* 🍞 **PASS** OS/2 fsType is properly set to zero.
</details>
<details>
<summary>🍞 <b>PASS:</b> Substitute copyright, registered and trademark symbols in name table entries.</summary>
* [com.google.fonts/check/name/unwanted_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/unwanted_chars)
* 🍞 **PASS** No need to substitute copyright, registered and trademark symbols in name table entries of this font.
</details>
<details>
<summary>🍞 <b>PASS:</b> Check copyright namerecords match license file.</summary>
@ -568,6 +553,13 @@ The version string must ideally include a git commit hash and either a 'dev' or
* [com.google.fonts/check/currency_chars](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/currency_chars)
* 🍞 **PASS** Font has all expected currency sign characters.
</details>
<details>
<summary>🍞 <b>PASS:</b> Are there non-ASCII characters in ASCII-only NAME table entries?</summary>
* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries)
* 🍞 **PASS** None of the ASCII-only NAME table entries contain non-ASCII characteres.
</details>
<details>
<summary>🍞 <b>PASS:</b> Checks METADATA.pb font.name field matches family name declared on the name table.</summary>
@ -732,6 +724,13 @@ The version string must ideally include a git commit hash and either a 'dev' or
* 🍞 **PASS** head macStyle ITALIC bit is properly set.
* 🍞 **PASS** head macStyle BOLD bit is properly set.
</details>
<details>
<summary>🍞 <b>PASS:</b> Copyright field for this font on METADATA.pb matches all copyright notice entries on the name table ?</summary>
* [com.google.fonts/check/metadata/nameid/copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/metadata/nameid/copyright)
* 🍞 **PASS** Copyright field for this font on METADATA.pb matches copyright notice entries on the name table.
</details>
<details>
<summary>🍞 <b>PASS:</b> Font has all mandatory 'name' table entries ?</summary>
@ -1097,5 +1096,5 @@ The version string must ideally include a git commit hash and either a 'dev' or
| 💔 ERROR | 🔥 FAIL | ⚠ WARN | 💤 SKIP | ℹ INFO | 🍞 PASS |
|:-----:|:----:|:----:|:----:|:----:|:----:|
| 0 | 11 | 6 | 19 | 7 | 107 |
| 0% | 7% | 4% | 13% | 5% | 71% |
| 0 | 8 | 6 | 19 | 7 | 110 |
| 0% | 5% | 4% | 13% | 5% | 73% |

53
googlefonts-qa/notes/QA-notes.md
View file

@ -4,7 +4,7 @@
## Checks to resolve
----------------------------
<details>
<summary>🔥 <b>FAIL:</b> Variable font weight coordinates must be multiples of 100.</summary>
@ -35,15 +35,43 @@
----------------------------
<details>
<summary>🔥 <b>FAIL:</b> Are there non-ASCII characters in ASCII-only NAME table entries?</summary>
<summary><b>[119] FiraCode-Light.ttf</b></summary>
<details>
<summary>🔥 <b>FAIL:</b> Checking file is named canonically.</summary>
* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries)
* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.
* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright &#169; 2015 by Nikita Prokopov''
* [com.google.fonts/check/canonical_filename](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/canonical_filename)
* 🔥 **FAIL** This is a variable font, but it is using a naming scheme typical of a static font.
* 🔥 **FAIL** Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF
</details>
<details>
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWeightClass.</summary>
* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass)
* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
</details>
- [ ] remove © symbol
======================================================================================
## Waiting on others
<details>
<summary>🔥 <b>FAIL:</b> Copyright notices match canonical pattern in fonts</summary>
* [com.google.fonts/check/font_copyright](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/font_copyright)
* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: 'Copyright 2017 The Familyname Project Authors (git url)'
But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica S.A., and Nikita Prokopov (https://github.com/tonsky/FiraCode)'
</details>
- additionally, it's unclear how the original copyright on Fira Mono & Fira Code should best be integrated to credit all designers involved
- [x] file issue on fontbakery (https://github.com/googlefonts/fontbakery/issues/2419)
- [ ] confirm that current approach is fine (https://github.com/google/fonts/issues/1460#issuecomment-476713822)
----------------------------
======================================================================================
@ -61,4 +89,17 @@
- [x] scale UPM to 2000
----------------------------
<details>
<summary>🔥 <b>FAIL:</b> Are there non-ASCII characters in ASCII-only NAME table entries?</summary>
* [com.google.fonts/check/name/ascii_only_entries](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/name/ascii_only_entries)
* 🔥 **FAIL** There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.
* ℹ **INFO** Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright &#169; 2015 by Nikita Prokopov''
</details>
- [x] remove © symbol
----------------------------