mirror of
https://github.com/olivierkes/manuskript.git
synced 2024-05-17 11:22:28 +12:00
3aa9cadfd8
A previous fix (5f9ea3) inadvertently broke the progress bar by converting to the wrong data type. (See issue #561 / PR #609). While checking the code I realized the problem occurred primarily because we weren't checking the validity of the values closer to the source. Doing so alleviates the need to check elsewhere. In the hope of inspiring a more systematic approach, a new uiParse() utility function has been added to curb the further growth of toXxx() functions that exist solely to validate user input. There is no doubt room for improvement, both on the end of the new uiParse() function as well as the spot where it is used. Ideally, the data that comes out of the model should already be 'safe', but since this is a bugfix for a bugfix I want to keep waves to a minimum. This commit fixes issue #652. |
||
|---|---|---|
| .. | ||
| converters | ||
| exporter | ||
| functions | ||
| importer | ||
| load_save | ||
| models | ||
| tests | ||
| ui | ||
| __init__.py | ||
| enums.py | ||
| loadSave.py | ||
| main.py | ||
| mainWindow.py | ||
| settings.py | ||
| settingsWindow.py | ||
| version.py | ||