1
0
Fork 0
mirror of synced 2024-06-27 02:31:04 +12:00

Avoid potential scope bug

This commit is contained in:
Jake Barnby 2022-02-24 15:18:11 +13:00
parent 4b280bef24
commit 2c2b9668d2

View file

@ -562,15 +562,15 @@ App::post('/v1/functions/:functionId/deployments')
if ($activate) {
// Remove deploy for all other deployments.
$deployments = $dbForProject->find('deployments', [
$activeDeployments = $dbForProject->find('deployments', [
new Query('activate', Query::TYPE_EQUAL, [true]),
new Query('resourceId', Query::TYPE_EQUAL, [$functionId]),
new Query('resourceType', Query::TYPE_EQUAL, ['functions'])
]);
foreach ($deployments as $deployment) {
$deployment->setAttribute('activate', false);
$dbForProject->updateDocument('deployments', $deployment->getId(), $deployment);
foreach ($activeDeployments as $activeDeployment) {
$activeDeployment->setAttribute('activate', false);
$dbForProject->updateDocument('deployments', $activeDeployment->getId(), $activeDeployment);
}
}