From 2c2b9668d2685e099ae1cc693d0cc75419899924 Mon Sep 17 00:00:00 2001
From: Jake Barnby <jakeb994@gmail.com>
Date: Thu, 24 Feb 2022 15:18:11 +1300
Subject: [PATCH] Avoid potential scope bug

---
 app/controllers/api/functions.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/controllers/api/functions.php b/app/controllers/api/functions.php
index e933bb844..075dfc649 100644
--- a/app/controllers/api/functions.php
+++ b/app/controllers/api/functions.php
@@ -562,15 +562,15 @@ App::post('/v1/functions/:functionId/deployments')
 
         if ($activate) {
             // Remove deploy for all other deployments.
-            $deployments = $dbForProject->find('deployments', [
+            $activeDeployments = $dbForProject->find('deployments', [
                 new Query('activate', Query::TYPE_EQUAL, [true]),
                 new Query('resourceId', Query::TYPE_EQUAL, [$functionId]),
                 new Query('resourceType', Query::TYPE_EQUAL, ['functions'])
             ]);
 
-            foreach ($deployments as $deployment) {
-                $deployment->setAttribute('activate', false);
-                $dbForProject->updateDocument('deployments', $deployment->getId(), $deployment);
+            foreach ($activeDeployments as $activeDeployment) {
+                $activeDeployment->setAttribute('activate', false);
+                $dbForProject->updateDocument('deployments', $activeDeployment->getId(), $activeDeployment);
             }
         }