CodeMirror/FiraCode
1
0
Fork 0
mirror of synced 2024-05-19 12:03:42 +12:00
Code Issues Projects Releases Wiki Activity

update notes to reflect weightClass fix

Browse source
This commit is contained in:
Stephen Nixon 2019-03-27 13:22:37 -04:00
parent 1567440ada
commit 99d72fe329
1 changed files with 17 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
googlefonts-qa/notes/QA-notes.md
View file

@ -1,22 +1,11 @@
# QA Notes – checking & polishing Fira Code for Google Fonts
- [x] autohint static TTFs
- [ ] check extrapolated outlines for issues
## Checks to resolve
<details>
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWeightClass.</summary>
* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass)
* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
</details>
- [ ] explore to find why this would be happening ...
- Encode Sans gets an OS/2 usWeightClass of `100`, matching its default instance.
**Solution**
- Custom Parameters of `Axis Location` needed to be set in source masters (https://github.com/googlei18n/fontmake/issues/540)
======================================================================================
@ -141,4 +130,20 @@ But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica
- [x] change if you find a better approach to keep Retina without disrupting builds / Regular weight
- To set up the instance in GlyhpsApp such that it exports a font as expected: "Retina" gets a custom parameter of `weightClass: 450`, and a glyphs menu-weight of "Normal." Tested in axis-praxis, it seems to work well. All instances have a `weightClass` custom parameter.
----------------------------
<details>
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWeightClass.</summary>
* [com.google.fonts/check/usweightclass](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/usweightclass)
* 🔥 **FAIL** OS/2 usWeightClass expected value for 'Light' is 300 but this font has 400.
</details>
- [ ] explore to find why this would be happening ...
- Encode Sans gets an OS/2 usWeightClass of `100`, matching its default instance.
**Solution**
- Custom Parameters of `Axis Location` needed to be set in source masters (https://github.com/googlei18n/fontmake/issues/540)
----------------------------