CodeMirror/uMatrix
1
0
Fork 0
mirror of https://github.com/gorhill/uMatrix.git synced 2024-06-16 17:24:59 +12:00
Code Issues Releases Wiki Activity

comment re potential redundant eval

Browse source
This commit is contained in:
gorhill 2014-12-24 08:29:55 -05:00
parent fb5d93d207
commit 0174955287
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/js/matrix.js
View file

@ -399,6 +399,12 @@ Matrix.prototype.evaluateCellZXY = function(srcHostname, desHostname, type) {
return Matrix.GreenIndirect;
}
// TODO: There are cells evaluated twice when the type is '*'. Unsure
// whether it's worth trying to avoid that, as this could introduce
// overhead which may not be gained back by skipping the redundant tests.
// And this happens *only* when building the matrix UI, not when
// evaluating net requests.
// Specific-hostname specific-type cell
var r = this.evaluateCellZ(srcHostname, desHostname, type);
if ( r === 1 ) { return Matrix.RedDirect; }