From 01749552873e7f8640f308ee537b7e83a6d54711 Mon Sep 17 00:00:00 2001 From: gorhill Date: Wed, 24 Dec 2014 08:29:55 -0500 Subject: [PATCH] comment re potential redundant eval --- src/js/matrix.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/js/matrix.js b/src/js/matrix.js index 1911bda..600259f 100644 --- a/src/js/matrix.js +++ b/src/js/matrix.js @@ -399,6 +399,12 @@ Matrix.prototype.evaluateCellZXY = function(srcHostname, desHostname, type) { return Matrix.GreenIndirect; } + // TODO: There are cells evaluated twice when the type is '*'. Unsure + // whether it's worth trying to avoid that, as this could introduce + // overhead which may not be gained back by skipping the redundant tests. + // And this happens *only* when building the matrix UI, not when + // evaluating net requests. + // Specific-hostname specific-type cell var r = this.evaluateCellZ(srcHostname, desHostname, type); if ( r === 1 ) { return Matrix.RedDirect; }