Commit graph

308 commits

Author SHA1 Message Date
Youness Alaoui 7c8458b0da Fix color scheme of fullscreen editor
Color scheme was inverted if foreground was transparent, bug and fix provided
by @tildagail [1] and the text on the left side panel was ignoring text color
settings, making it unreadable in dark themes, as reported by @worstje in #527

[1] https://github.com/olivierkes/manuskript/issues/527#issuecomment-469578130
2019-03-29 10:22:55 -06:00
Youness Alaoui a6942b7923 Fix crash when right-clicking twice on fullscreen panel
If you right click once on the fullscreen panel and the context menu pop up
then you right click again somewhere else on the panel *while the previous
context menu is still visible* then it will cause a crash with :
"Windows fatal exception: access violation"
It seems to be caused by a crash in the QT event loop, trying to delete the
existing QMenu within an event handler.
2019-02-28 10:58:23 -07:00
Youness Alaoui 3f217257c4 Fix background of popup menus that was transparent (black)
In the properties view, the context menu on the title line would be black
making its content unreadable. Same in the filter line of the "Set Custom icon"
window on the outline's context menu.
2019-02-27 10:49:05 -07:00
Curtis Gedak 4fdacc24f7 Ensure text file open methods use utf-8 encoding
Several crashes were encountered opening files on operating systems
that do not default to UTF-8 encoding, such as Windows.  In each case
the project file appears to have become corrupted.  Because the only
reports to date have been on Windows, attempt to fix by specifying
utf-8 encoding for all text file open methods.

See issues #331, #470, and #502.
2019-02-27 09:30:16 -07:00
Youness Alaoui 7928ea2796 Fix corkView background image on Windows
Windows path to the image has '\' path separator instead of '/' which makes
the stylesheet fail. Background images don't appear and console gets spammed with :
Could not parse stylesheet of object corkView(0x27248eb6900, name = "corkView")
2019-02-26 13:25:30 -07:00
Youness Alaoui c3c9eef415 Do not default spellcheck to True for new editor views
default spellcheck to the settings value instead. Otherwise any new editor tab
will have spellcheck enabled regardless of setting.

Fixes #474
2019-02-25 12:58:00 -07:00
Youness Alaoui 84d0979ffb Set editor theme stylesheet to QTextEdit only.
This prevents any child widget from inheriting the same stylesheet,
more specifically, the context menu of the full screen editor will now
appear normal instead of being black text on black background, which made
it unreadable.

Fixes #440
2019-02-25 11:15:16 -07:00
Youness Alaoui 4a9937f041 Do not use a lambda function in the fullScreenEditor's myScrollBar timer signal
The lambda function will keep a reference to the scrollbar python object preventing it
from getting destroyed when the QScrollbar is destroyed. This causes the underlying
QT widget to be freed while the python object still exists, therefore the timer itself
doesn't get stopped/cleaned, so the timer will get called and cause a crash with :
"RuntimeError: Wrapped C/C++ object of type myScrollbar has been deleted"

To reproduce, press F11 repeatedly while scrolling.
2019-02-25 10:22:48 -07:00
Curtis Gedak baeb5f4653 2nd try to fix macOS X blank screen when leaving fullscreen editor mode
See issue #24.

The first attempt to fix this problem was with commit:

    Try to fix macOS X blank screen when leaving editor fullscreen mode
    1ae0a77464
2019-02-12 11:23:29 -07:00
Youness Alaoui 9b774d327f Fix crash when right clicking a word in editor and enchant is not installed. 2019-02-11 12:35:23 -07:00
Youness Alaoui caed3e9224 Fix crash when 7 pound signs are written alone on a line.
The code would look for trailing pound signs and would
count all the way to the beginning and beyond, resulting
in an out of bounds exception.
2019-02-10 09:54:50 -07:00
Curtis Gedak 1ae0a77464 Try to fix macOS X blank screen when leaving editor fullscreen mode
Ensure showNormal() is called after leaving showFullScreen().

See issue #24.

References:

https://stackoverflow.com/questions/31666744/pyqt5-can-not-close-a-topmost-fullscreen-qdialog-on-mac-osx

https://doc.qt.io/qt-5/qwidget.html#showFullScreen
  - To return from full-screen mode, call showNormal().

https://pythonprogramminglanguage.com/destructor/
2019-02-09 10:27:44 -07:00
Curtis Gedak f75bc69dd7 Fix spelling mistake "chose" should be "choose"
Mentioned in issue #470
2019-02-07 12:34:57 -07:00
Allan Nordhøy f731e19e00 Spelling: Manuscript, may have to be restarted (#454)
* Spelling: Manuscript, may have to be restarted
2019-01-10 10:26:14 -07:00
LingSamuel cbf35fa373 Open/Save As/Create last accessed directory 2018-12-07 12:01:33 -07:00
LingSamuel 7bbc112d25 Add last accessed directory 2018-12-07 12:01:33 -07:00
Curtis Gedak 0cbf337f09 ========== manuskript-0.8.0 ========== 2018-12-05 11:39:28 -07:00
Curtis Gedak 528ea130ee Remove unimplemented snowflake view mode menu entry
The menu option "View -> Mode -> Snowflake" has not been implemented.
This greyed out / disabled option has caused some confusion for users.
Remove the snowflake menu option to avoid confusion.

Closes issue #419
See also earlier issue #45
2018-11-30 09:42:42 -07:00
Curtis Gedak 5ea37bd192 Remove plot resolution step key bindings Ctrl+Enter and Ctrl+Backspace
Many applications, including Manuskript in the Editor pane, use the
keyboard shortcut 'Ctrl+Backspace' to delete the previous word.
However in the Plot pane Manuskript uses 'Ctrl+Backspace' to delete a
plot resolution step.

Fix this inconsistent behaviour by removing the keyboard shortcuts for
'Ctrl+Enter' and 'Ctrl+Backspace' from the Plot pane.

Closes issue #375
2018-11-26 11:05:46 -07:00
Curtis Gedak 60b58d9658 Fix Python 3.7 DeprecationWarning use local.format_string() messages
Fix by replacing locale.format() with locale.format_string().
2018-11-16 12:52:56 -07:00
Curtis Gedak 7f592bae41 Fix Python 3.6 DeprecationWarning invalid escape sequence messages
Fix by ensuring that regular expressions are constructed using either
raw string literals [1] or double backslashes [2].

[1] https://stackoverflow.com/questions/44325948/pandas-invalid-escape-sequence-after-update
[2] https://github.com/joblib/joblib/pull/526

Note that python only shows the deprecation warnings on initial run [3].

[3] https://bugs.python.org/issue30091

To work around this issue, remove the cached bytecode with:

    find . -name "__pycache__" -exec rm -rf {} \;

Then to prevent compiling to bytecode add the "-B" option to python:

    python3 -B -m pytest -vs
2018-11-16 12:52:56 -07:00
Curtis Gedak b0774b4149 Fix segmentation fault on import
Manuskript started to segmentation fault on import starting with Qt 5.11.

I found the following link and the Qt bug links within to be useful in
my trouble-shooting efforts.

[Qt 5.11] Various Applications Segfault in 'libfm-qt'
https://github.com/lxqt/libfm-qt/issues/164

Closes issue #402
2018-11-11 13:31:06 -07:00
RiderExMachina 41e9467267 Fix crash in Outline mode with multi-item select #355
Closes issue #355 and pull request #385
2018-10-14 11:10:46 -06:00
Curtis Gedak 21423734e9 Revert "Minor grammar fixes"
This reverts commit 2fdf8c64bf.

The problem introduced by the commit is that the Editor pane would
incorrectly label book elements with the plural form of a word.  For
example "Books 4", "Sections 2", "Chapters 1", or "Scenes 3".  Hence
the need to undo the commit.

Closes issue #383.
2018-09-20 14:57:44 -06:00
RiderExMachina 2fdf8c64bf Minor grammar fixes
Fix grammar regarding multiple of an object.
2018-09-11 10:32:51 -06:00
Curtis Gedak 378f03c0b6 Clear Cheatsheet results when filter text empty 2018-08-14 09:04:00 -06:00
Curtis Gedak 713528a239 Fix crash if Cheatsheet filter term not found and Enter key pressed #354
See issue #354.
2018-08-14 09:04:00 -06:00
Windspar 67db180c25 Fixes #217 - segfault when pasting text with focus mode enabled 2018-03-08 11:19:25 -07:00
JackXVII d3afa11ceb Remove _updateIndexFromID from textEditView
It is not used anymore.
2018-03-03 12:53:52 -07:00
JackXVII 3a21ddd137 Use QPersistentModelIndex in textEditView
It is much simpler than catching rowsAboutToBeDeleted signal from model. Also
it fixes #306.
2018-03-03 12:53:52 -07:00
Curtis Gedak 63b471e10d Make word match for spell check exclude underscore from words
See issue #283.

Adds (?!_) to perform negative lookahead to exclude "_" from pattern match.

https://stackoverflow.com/questions/14858346/regular-expressions-how-to-express-w-without-underscore
2018-02-20 10:51:57 -07:00
Windspar 4638ba878f stop crash when click btnGoUp and current editor is None 2018-02-18 14:06:33 -05:00
Curtis Gedak 43c077552a Avoid crash on spellcheck by ensuring enchant dictionary exists
See issue #273.
2018-02-12 10:59:14 -07:00
Sebastian Rasmussen dde836e0f4 Fix typos that are visible to end-users. 2018-01-29 10:30:41 -07:00
Sebastian Rasmussen dfe88a9681 Fix typos in code comments, invisible to end-users. 2018-01-29 10:30:41 -07:00
Olivier Keshavjee 4a9dc00381 Fixes #307: Overlay status bar prevents access to add/delete world item icons when displaying a message 2018-01-22 18:19:22 +01:00
JackXVII fe617f871f Adds moving World items. #219 2018-01-11 23:44:50 +03:00
Olivier Keshavjee 3c140d755f Adds "Sentence mode" to Focus mode. #259 2017-12-15 20:56:40 +01:00
Olivier Keshavjee 19f8938852 Corrects bug in links tooltips 2017-12-15 20:12:51 +01:00
Olivier Keshavjee a6a82d1bba Clickable links: adds tip to tooltip 2017-12-14 15:06:51 +01:00
Olivier Keshavjee cd8ad6cc3a Adds: clickable links, and display images as tooltips (#22, #215) 2017-12-14 14:55:14 +01:00
Olivier Keshavjee e76b9b4a1c Another take on status bar (#262) 2017-12-08 10:20:33 +01:00
Olivier Keshavjee 1764baf292 Fixes a bug introduced when fixing #261 2017-12-06 18:53:42 +01:00
Olivier Keshavjee d521fc0771 Fixes #261: Manuskript response slow with recent addition of focus mode 2017-12-06 18:41:26 +01:00
Olivier Keshavjee 46384b68eb Fixes bugs in focus mode (#259) 2017-12-05 23:45:16 +01:00
Olivier Keshavjee 826d53933f Adds #259: Focus Mode (poke #234) 2017-12-05 23:18:32 +01:00
Olivier Keshavjee 25911876eb Fixes #246: Index card status can spillover 2017-12-04 13:52:58 +01:00
Olivier Keshavjee 9cbd8887c7 Fixes #240: Cannot write a summary on a plot resolution step 2017-12-04 13:27:57 +01:00
Olivier Keshavjee 9c635301b5 Adds #223: command line parameter to open project 2017-11-30 17:47:23 +01:00
Olivier Keshavjee ca39121826 UI tweaks 2017-11-30 17:18:53 +01:00