Commit graph

88 commits

Author SHA1 Message Date
Youness Alaoui 7c8458b0da Fix color scheme of fullscreen editor
Color scheme was inverted if foreground was transparent, bug and fix provided
by @tildagail [1] and the text on the left side panel was ignoring text color
settings, making it unreadable in dark themes, as reported by @worstje in #527

[1] https://github.com/olivierkes/manuskript/issues/527#issuecomment-469578130
2019-03-29 10:22:55 -06:00
Youness Alaoui a6942b7923 Fix crash when right-clicking twice on fullscreen panel
If you right click once on the fullscreen panel and the context menu pop up
then you right click again somewhere else on the panel *while the previous
context menu is still visible* then it will cause a crash with :
"Windows fatal exception: access violation"
It seems to be caused by a crash in the QT event loop, trying to delete the
existing QMenu within an event handler.
2019-02-28 10:58:23 -07:00
Youness Alaoui c3c9eef415 Do not default spellcheck to True for new editor views
default spellcheck to the settings value instead. Otherwise any new editor tab
will have spellcheck enabled regardless of setting.

Fixes #474
2019-02-25 12:58:00 -07:00
Youness Alaoui 84d0979ffb Set editor theme stylesheet to QTextEdit only.
This prevents any child widget from inheriting the same stylesheet,
more specifically, the context menu of the full screen editor will now
appear normal instead of being black text on black background, which made
it unreadable.

Fixes #440
2019-02-25 11:15:16 -07:00
Youness Alaoui 4a9937f041 Do not use a lambda function in the fullScreenEditor's myScrollBar timer signal
The lambda function will keep a reference to the scrollbar python object preventing it
from getting destroyed when the QScrollbar is destroyed. This causes the underlying
QT widget to be freed while the python object still exists, therefore the timer itself
doesn't get stopped/cleaned, so the timer will get called and cause a crash with :
"RuntimeError: Wrapped C/C++ object of type myScrollbar has been deleted"

To reproduce, press F11 repeatedly while scrolling.
2019-02-25 10:22:48 -07:00
Curtis Gedak baeb5f4653 2nd try to fix macOS X blank screen when leaving fullscreen editor mode
See issue #24.

The first attempt to fix this problem was with commit:

    Try to fix macOS X blank screen when leaving editor fullscreen mode
    1ae0a77464
2019-02-12 11:23:29 -07:00
Curtis Gedak 1ae0a77464 Try to fix macOS X blank screen when leaving editor fullscreen mode
Ensure showNormal() is called after leaving showFullScreen().

See issue #24.

References:

https://stackoverflow.com/questions/31666744/pyqt5-can-not-close-a-topmost-fullscreen-qdialog-on-mac-osx

https://doc.qt.io/qt-5/qwidget.html#showFullScreen
  - To return from full-screen mode, call showNormal().

https://pythonprogramminglanguage.com/destructor/
2019-02-09 10:27:44 -07:00
Curtis Gedak 60b58d9658 Fix Python 3.7 DeprecationWarning use local.format_string() messages
Fix by replacing locale.format() with locale.format_string().
2018-11-16 12:52:56 -07:00
Curtis Gedak 7f592bae41 Fix Python 3.6 DeprecationWarning invalid escape sequence messages
Fix by ensuring that regular expressions are constructed using either
raw string literals [1] or double backslashes [2].

[1] https://stackoverflow.com/questions/44325948/pandas-invalid-escape-sequence-after-update
[2] https://github.com/joblib/joblib/pull/526

Note that python only shows the deprecation warnings on initial run [3].

[3] https://bugs.python.org/issue30091

To work around this issue, remove the cached bytecode with:

    find . -name "__pycache__" -exec rm -rf {} \;

Then to prevent compiling to bytecode add the "-B" option to python:

    python3 -B -m pytest -vs
2018-11-16 12:52:56 -07:00
Windspar 4638ba878f stop crash when click btnGoUp and current editor is None 2018-02-18 14:06:33 -05:00
Sebastian Rasmussen dfe88a9681 Fix typos in code comments, invisible to end-users. 2018-01-29 10:30:41 -07:00
Olivier Keshavjee c504cb510e Fixes fullScreen scrollbar range 2017-11-28 19:58:23 +01:00
Olivier Keshavjee cb79e504e7 Merge branch 'master' into develop 2017-11-27 21:53:37 +01:00
Olivier Keshavjee c2dcbf56a0 Adds new markdown highlighter and many little tweaks 2017-11-27 21:35:32 +01:00
Olivier Keshavjee 7b29d332c5 Removes textFormat panel (bold, italic, etc. buttons) 2017-11-27 20:58:02 +01:00
Olivier Keshavjee c1ad771642 Subclass textEditView 2017-11-27 15:00:07 +01:00
Olivier Keshavjee 7940cdb336 Adds better fullscreen theme color integration 2017-11-25 14:17:49 +01:00
Olivier Keshavjee 59742accfa Moves textedit scrollbar outside the margins 2017-11-24 22:33:12 +01:00
Olivier Keshavjee 52af71757e Adds: better harmonization between Documents menu and context menu #229 2017-11-24 20:50:18 +01:00
Curtis Gedak a8ed0f5767 Change "informations" to "information"
See issue #181.
2017-11-23 12:43:31 -07:00
Olivier Keshavjee 9be2edeee7 Checkpoint: adding new markdown highlighter 2017-11-22 13:43:40 +01:00
Olivier Keshavjee cf4c1c83bf Changes every Enum to IntEnum 2017-11-15 21:05:48 +01:00
Olivier Keshavjee 9e95196cc5 Changes Outline enums to IntEnum 2017-11-15 20:58:12 +01:00
Olivier Keshavjee bc0d6f5760 Creates base classes 2017-11-15 20:34:05 +01:00
Olivier Keshavjee 170c8ef404 Fixes #194: Editor tab should trim long titles 2017-11-14 18:11:50 +01:00
Olivier Keshavjee 31dcc6d53a Adds better style colors of references 2017-11-14 15:22:16 +01:00
Olivier Keshavjee a334e8bd1b Improves theme desktop integration greatly 2017-11-14 15:01:20 +01:00
Olivier Keshavjee ee212db39c Removes most of hard-coded colors 2017-11-14 14:56:11 +01:00
Olivier Keshavjee 2109f88816 Improves colors of goal progress bar 2017-11-14 10:36:57 +01:00
Olivier Keshavjee 1aa6afc2bc Fixes: One white pixel visible in full screen mode #210 2017-11-12 20:48:27 +01:00
Olivier Keshavjee bb57d3d057 Adds: merge 2017-11-10 17:21:02 +01:00
Olivier Keshavjee a153606811 Adds: split dialog, split at cursor 2017-11-10 16:31:40 +01:00
Olivier Keshavjee 3b17c4e2b4 Adds: Menu Documents. Edit operations (copy, cut, paste, duplicate, remove), and Move up and down. 2017-11-10 11:35:53 +01:00
Olivier Keshavjee 15ccaa513b Adds: import documents from several sources (txt, md, html, epub, docx, OPML, odt, etc.) #200 2017-11-09 15:21:25 +01:00
Olivier Keshavjee 543d5a232a Checkpoint: preview seems to work 2017-11-07 14:25:47 +01:00
Olivier Keshavjee 221c7a181d Checkpoint: basic mechanics of settings implemented 2017-11-07 11:25:19 +01:00
Olivier Keshavjee 0a0649a0db Fixes: Manuskript crashes when a wrong locale is set. See #188. 2017-11-06 18:29:18 +01:00
Olivier Keshavjee 572feb5409 Creates empty import window 2017-11-06 09:16:44 +01:00
Olivier 1f04bf6f54
Merge pull request #192 from camstevenson/import-export
Adds: Import OPML
2017-11-06 08:21:06 +01:00
Cam Stevenson 1fa86ddd73 Finish OPML Import 2017-11-05 08:24:25 -05:00
Olivier Keshavjee 648b4b67eb Fixes more bugs in drag n drop: seg fault when creating an item after deleting an item that was open for editing, and other small stuff 2017-10-20 23:39:57 +02:00
Olivier Keshavjee 1a8d4c5c72 Adds some docstrings on editor/view classes, because I never remember who they are and what they do... 2017-10-20 16:20:33 +02:00
Olivier Keshavjee a44dd41f00 Fixes bug in drag'n'drop: item can be dropped into itself (or children of itself) 2017-10-20 15:28:37 +02:00
Olivier Keshavjee 6ec0c19376 Corrects: Spell checker is active for partial words. #166 2017-10-19 22:48:49 +02:00
Olivier Keshavjee ee058a309f Fixes: Spell checker is active for partial words. #166 2017-10-19 13:33:36 +02:00
Olivier Keshavjee 3eda56ed5a Tries to fix 'Indent not saved in custom full screen theme #133', and adds cache to theme thumbnails 2017-10-18 10:13:22 +02:00
Olivier Keshavjee 4e74da41d1 Working on: Request: Justified formatting of text #148 2017-10-17 13:05:46 +02:00
Olivier Keshavjee d7407afb8f Fixes: In revision mode text, selecting group doesn't load text-preferences right. #51 2017-10-16 00:40:41 +02:00
Olivier Keshavjee 67efc47a18 Spell checking works but does not underline misspelled words #147 2017-10-15 22:45:57 +02:00
Olivier Keshavjee a6123292ae Adds: go-up button. See #157 2017-10-14 21:39:16 +02:00