CodeMirror/manuskript
1
0
Fork 0
mirror of https://github.com/olivierkes/manuskript.git synced 2024-05-17 11:22:28 +12:00
Code Issues Projects Releases Wiki Activity

Does not simply warn of duplicate IDs, but fixes them.

Browse source
This commit is contained in:
Olivier Keshavjee 2022-01-22 09:53:36 +01:00
parent 47b55ba164
commit 0330336311
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
manuskript/models/abstractItem.py
View file

@ -224,15 +224,23 @@ class abstractItem():
if max([self.IDs.count(i) for i in self.IDs if i]) != 1:
LOGGER.warning("There are some items with overlapping IDs: %s", [i for i in self.IDs if i and self.IDs.count(i) != 1])
_IDs = [self.ID()]
def checkChildren(item):
"Check recursively every children and give them unique, non-empty, non-zero IDs."
for c in item.children():
_id = c.ID()
if not _id or _id == "0":
if not _id or _id == "0" or _id in _IDs:
c.getUniqueID()
LOGGER.warning("* Item {} '{}' is given new unique ID: '{}'".format(_id, c.title(), c.ID()))
_IDs.append(_id)
checkChildren(c)
checkChildren(self)
# Not sure if self.IDs is still useful (it was used in the old unique ID generating system at least).
# It might be deleted everywhere. But just in the meantime, it should at least be up to date.
self.IDs = self.listAllIDs()
def listAllIDs(self):
IDs = [self.ID()]
for c in self.children():