CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-10-01 09:38:55 +13:00
Code Issues Projects Releases Wiki Activity

Fix issue with determining when to hide sensitive fields from query definitions and never delete the query schema

Browse source
This commit is contained in:
Andrew Kingston 2021-11-25 11:21:54 +00:00
parent e4e29ce1b2
commit 38219f0ea3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/server/src/api/controllers/query.js
View file

@ -1,6 +1,10 @@
const { processString } = require("@budibase/string-templates") const { processString } = require("@budibase/string-templates")
const CouchDB = require("../../db") const CouchDB = require("../../db")
const { generateQueryID, getQueryParams } = require("../../db/utils") const {
generateQueryID,
getQueryParams,
isProdAppID,
} = require("../../db/utils")
const { BaseQueryVerbs } = require("../../constants") const { BaseQueryVerbs } = require("../../constants")
const env = require("../../environment") const env = require("../../environment")
const { Thread, ThreadType } = require("../../threads") const { Thread, ThreadType } = require("../../threads")
@ -90,10 +94,9 @@ exports.find = async function (ctx) {
const db = new CouchDB(ctx.appId) const db = new CouchDB(ctx.appId)
const query = enrichQueries(await db.get(ctx.params.queryId)) const query = enrichQueries(await db.get(ctx.params.queryId))
// remove properties that could be dangerous in real app // remove properties that could be dangerous in real app
if (env.isProd()) { if (isProdAppID(ctx.appId)) {
delete query.fields delete query.fields
delete query.parameters delete query.parameters
delete query.schema
} }
ctx.body = query ctx.body = query
} }