From 38219f0ea386d4857be920a86106d30594a37c13 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Thu, 25 Nov 2021 11:21:54 +0000 Subject: [PATCH] Fix issue with determining when to hide sensitive fields from query definitions and never delete the query schema --- packages/server/src/api/controllers/query.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/server/src/api/controllers/query.js b/packages/server/src/api/controllers/query.js index 502ef5e67b..80da246166 100644 --- a/packages/server/src/api/controllers/query.js +++ b/packages/server/src/api/controllers/query.js @@ -1,6 +1,10 @@ const { processString } = require("@budibase/string-templates") const CouchDB = require("../../db") -const { generateQueryID, getQueryParams } = require("../../db/utils") +const { + generateQueryID, + getQueryParams, + isProdAppID, +} = require("../../db/utils") const { BaseQueryVerbs } = require("../../constants") const env = require("../../environment") const { Thread, ThreadType } = require("../../threads") @@ -90,10 +94,9 @@ exports.find = async function (ctx) { const db = new CouchDB(ctx.appId) const query = enrichQueries(await db.get(ctx.params.queryId)) // remove properties that could be dangerous in real app - if (env.isProd()) { + if (isProdAppID(ctx.appId)) { delete query.fields delete query.parameters - delete query.schema } ctx.body = query }