PR review changes

Dockerfile

@@ -33,6 +33,7 @@ ENV PHP_REDIS_VERSION=5.3.7 \
     PHP_MONGODB_VERSION=1.9.1 \
     PHP_SWOOLE_VERSION=v4.8.7 \
     PHP_IMAGICK_VERSION=3.7.0 \
+    PHP_SCRYPT_VERSION=v1.4.2 \
     PHP_YAML_VERSION=2.2.2 \
     PHP_MAXMINDDB_VERSION=v1.11.0
 
@@ -97,7 +98,7 @@ RUN \
 ## Scrypt Extension
 FROM compile AS scrypt
 RUN \
-  git clone --depth 1 --branch master https://github.com/DomBlack/php-scrypt.git && \
+  git clone --depth 1 --branch $PHP_SCRYPT_VERSION https://github.com/DomBlack/php-scrypt.git && \
   cd php-scrypt && \
   phpize && \
   ./configure --enable-scrypt && \

src/Appwrite/Auth/Auth.php

@@ -10,12 +10,12 @@ class Auth
 
     const SUPPORTED_ALGOS = [
         'argon2' => 'Argon2',
-        'bcrypt' => 'BCrypt',
-        'md5' => 'MD5',
-        'sha' => 'SHA',
-        'phpass' => 'PHPass',
-        'scrypt' => 'SCrypt',
-        'scrypt_mod' => 'SCryptModified',
+        'bcrypt' => 'Bcrypt',
+        'md5' => 'Md5',
+        'sha' => 'Sha',
+        'phpass' => 'Phpass',
+        'scrypt' => 'Scrypt',
+        'scrypt_mod' => 'Scryptmodified',
         'plaintext' => '' // This is alias for DX purposes. It is translated to default algo
     ];
 

src/Appwrite/Auth/Hash/Bcrypt.php

@@ -11,7 +11,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: https://www.php.net/manual/en/password.constants.php
 */
-class BCrypt extends Hash
+class Bcrypt extends Hash
 {
     /**
      * @param string $password Input password to hash

src/Appwrite/Auth/Hash/Md5.php

@@ -9,7 +9,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: https://www.php.net/manual/en/function.md5.php
 */
-class MD5 extends Hash
+class Md5 extends Hash
 {
     /**
      * @param string $password Input password to hash

src/Appwrite/Auth/Hash/Phpass.php

@@ -32,7 +32,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: 
 */
-class PHPass extends Hash
+class Phpass extends Hash
 {
 	/**
 	 * Alphabet used in itoa64 conversions.

src/Appwrite/Auth/Hash/PlainText.php

@@ -1,42 +0,0 @@
-<?php
-
-namespace Appwrite\Auth\Hash;
-
-use Appwrite\Auth\Hash;
-
-/*
- * PlainText accepted options:
- * none
- * 
- * Refference: None. Simple plain text stored.
-*/
-class PlainText extends Hash
-{
-    /**
-     * @param string $password Input password to hash
-     * 
-     * @return string hash
-     */
-    public function hash(string $password): string {
-        return $password;
-    }
-
-    /**
-     * @param string $password Input password to validate
-     * @param string $hash Hash to verify password against
-     * 
-     * @return boolean true if password matches hash
-     */
-    public function verify(string $password, string $hash): bool {
-        return $password === $hash;
-    }
-
-    /**
-     * Get default options for specific hashing algo
-     * 
-     * @return mixed options named array
-     */
-    public function getDefaultOptions(): mixed {
-        return [];
-    }
-}

src/Appwrite/Auth/Hash/Scrypt.php

@@ -14,7 +14,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: https://github.com/DomBlack/php-scrypt/blob/master/scrypt.php#L112-L116
 */
-class SCrypt extends Hash
+class Scrypt extends Hash
 {
     /**
      * @param string $password Input password to hash

src/Appwrite/Auth/Hash/Scryptmodified.php

@@ -13,7 +13,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: https://github.com/DomBlack/php-scrypt/blob/master/scrypt.php#L112-L116
 */
-class SCryptModified extends Hash
+class Scryptmodified extends Hash
 {
     /**
      * @param string $password Input password to hash

src/Appwrite/Auth/Hash/Sha.php

@@ -13,7 +13,7 @@ use Appwrite\Auth\Hash;
  * 
  * Refference: https://www.php.net/manual/en/function.hash-algos.php
 */
-class SHA extends Hash
+class Sha extends Hash
 {
     /**
      * @param string $password Input password to hash

src/Appwrite/Utopia/Response/Model/User.php

@@ -33,7 +33,7 @@ class User extends Model
                 'type' => self::TYPE_STRING,
                 'description' => 'Password hashing algorithm.',
                 'default' => '',
-                'example' => 'bcrypt',
+                'example' => 'argon2',
             ])
             ->addRule('hashOptions', [
                 'type' => self::TYPE_STRING,