CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-06-27 02:31:04 +12:00
Code Issues Projects Releases Wiki Activity

PR review changes

Browse source
This commit is contained in:
Matej Bačo 2024-03-04 08:50:50 +00:00
parent ae77a2466b
commit d4e4337c57
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/api/account.php
View file

@ -3788,7 +3788,7 @@ App::patch('/v1/account/mfa/recovery-codes')
$queueForEvents->setParam('userId', $user->getId());
$document = new Document([
'recoveryCodes' => $mfaRecoveryCodes
'recoveryCodes' => $mfaRecoveryCodes
]);
$response->dynamic($document, Response::MODEL_MFA_RECOVERY_CODES);

2
app/controllers/api/users.php
View file

@ -1711,7 +1711,7 @@ App::put('/v1/users/:userId/mfa/recovery-codes')
$queueForEvents->setParam('userId', $user->getId());
$document = new Document([
'recoveryCodes' => $mfaRecoveryCodes
'recoveryCodes' => $mfaRecoveryCodes
]);
$response->dynamic($document, Response::MODEL_MFA_RECOVERY_CODES);

6
app/controllers/shared/api/auth.php
View file

@ -13,17 +13,17 @@ App::init()
->groups(['mfaProtected'])
->inject('session')
->action(function (Document $session) {
$isSessionSafe = false;
$isSessionFresh = false;
$lastUpdate = $session->getAttribute('mfaUpdatedAt');
if (!empty($lastUpdate)) {
$now = DateTime::now();
$maxAllowedDate = DateTime::addSeconds($lastUpdate, Auth::MFA_RECENT_DURATION); // Maximum date until session is considered safe before asking for another challenge
$isSessionSafe = DateTime::formatTz($maxAllowedDate) >= DateTime::formatTz($now);
$isSessionFresh = DateTime::formatTz($maxAllowedDate) >= DateTime::formatTz($now);
}
if (!$isSessionSafe) {
if (!$isSessionFresh) {
throw new Exception(Exception::USER_CHALLENGE_REQUIRED);
}
});

2
src/Appwrite/Auth/Auth.php
View file

@ -89,7 +89,7 @@ class Auth
/**
* MFA
*/
public const MFA_RECENT_DURATION = 600; // 5 minutes
public const MFA_RECENT_DURATION = 1800; // 30 mins
/**
* @var string