CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-07-04 06:00:53 +12:00
Code Issues Projects Releases Wiki Activity

Merge pull request #4985 from munyoudoum/fix-4982-email-session-expire-string-formattz

Browse source 
Fix 4982 email session expire string formattz
This commit is contained in:
Torsten Dittmann 2023-02-24 15:24:05 +05:30 committed by GitHub
parent 7d7ac9757b dacb713450
commit d043a74082
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGES.md
View file

@ -1,4 +1,5 @@
# Version TBD
- Fix expire to formatTz in create account session [#4985](https://github.com/appwrite/appwrite/pull/4985)
- Fix not storing function's response on response codes 5xx [#4610](https://github.com/appwrite/appwrite/pull/4610)
# Version 1.2.1

2
app/controllers/api/account.php
View file

@ -188,7 +188,7 @@ App::post('/v1/account/sessions/email')
$detector = new Detector($request->getUserAgent('UNKNOWN'));
$record = $geodb->get($request->getIP());
$expire = DateTime::addSeconds(new \DateTime(), $duration);
$expire = DateTime::formatTz(DateTime::addSeconds(new \DateTime(), $duration));
$secret = Auth::tokenGenerator();
$session = new Document(array_merge(
[

2
tests/e2e/Services/Account/AccountBase.php
View file

@ -121,6 +121,7 @@ trait AccountBase
]);
$this->assertEquals($response['headers']['status-code'], 201);
$this->assertNotFalse(\DateTime::createFromFormat('Y-m-d\TH:i:s.uP', $response['body']['expire']));
$sessionId = $response['body']['$id'];
$session = $this->client->parseCookie((string)$response['headers']['set-cookie'])['a_session_' . $this->getProject()['$id']];
@ -135,6 +136,7 @@ trait AccountBase
]);
$this->assertEquals($response['headers']['status-code'], 201);
$this->assertNotFalse(\DateTime::createFromFormat('Y-m-d\TH:i:s.uP', $response['body']['expire']));
/**
* Test for FAILURE