CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-09-29 08:51:28 +13:00
Code Issues Projects Releases Wiki Activity

chore: review comments

Browse source
This commit is contained in:
Christy Jacob 2023-09-06 22:08:26 +00:00
parent 1a0054890d
commit c439202d3c
2 changed files with 25 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
CHANGES.md
View file

@ -2,23 +2,24 @@
## Fixes
## Changes
- Fix create phone session abuse key [#6134][https://github.com/appwrite/appwrite/pull/6134]
- Fix CLI backwards compatibility [#6125](https://github.com/appwrite/appwrite/pull/6125)
* Override forEachDocument() to skip the cache collection [#6144](https://github.com/appwrite/appwrite/pull/6144)
* Fix Not Found error when deploying function from git [#6133](https://github.com/appwrite/appwrite/pull/6133)
* Add required params for scheduled functions [#6148](https://github.com/appwrite/appwrite/pull/6148)
* Update the error message for router_domain_not_configured [#6145](https://github.com/appwrite/appwrite/pull/6145)
* Fix _APP_EXECUTOR_HOST for upgrades [#6141](https://github.com/appwrite/appwrite/pull/6141)
* Change executor hostname back to appwrite-executor [#6160](https://github.com/appwrite/appwrite/pull/6160)
* Fix create execution request filter from previous SDK version [#6146](https://github.com/appwrite/appwrite/pull/6146)
* Make URL optional for Create Membership API and Serverside Requests [#6157](https://github.com/appwrite/appwrite/pull/6157)
* Support for v2 functions [#6142](https://github.com/appwrite/appwrite/pull/6142)
* Fix migrations worker [#6116](https://github.com/appwrite/appwrite/pull/6116)
* Fix: Global variables by [#6150](https://github.com/appwrite/appwrite/pull/6150)
* Fix webhook secret validation and executor path validation [#6162](https://github.com/appwrite/appwrite/pull/6162)
* Fix: Untrusted custom domains + auto-ssl [#6155](https://github.com/appwrite/appwrite/pull/6155)
* Fix: AI Assistant [#6153](https://github.com/appwrite/appwrite/pull/6153)
## Changes
* Add required params for scheduled functions [#6148](https://github.com/appwrite/appwrite/pull/6148)
* Update the error message for router_domain_not_configured [#6145](https://github.com/appwrite/appwrite/pull/6145)
* Override forEachDocument() to skip the cache collection [#6144](https://github.com/appwrite/appwrite/pull/6144)
* Support for v2 functions [#6142](https://github.com/appwrite/appwrite/pull/6142)
* Change executor hostname back to appwrite-executor [#6160](https://github.com/appwrite/appwrite/pull/6160)
* Make URL optional for Create Membership API and Serverside Requests [#6157](https://github.com/appwrite/appwrite/pull/6157)
# Version 1.4.1

29
src/Appwrite/Migration/Version/V19.php
View file

@ -707,19 +707,22 @@ class V19 extends Migration
$commands = $this->getFunctionCommands($document);
$document->setAttribute('commands', $document->getAttribute('commands', $commands));
$schedule = $this->consoleDB->createDocument('schedules', new Document([
'region' => App::getEnv('_APP_REGION', 'default'), // Todo replace with projects region
'resourceType' => 'function',
'resourceId' => $document->getId(),
'resourceInternalId' => $document->getInternalId(),
'resourceUpdatedAt' => DateTime::now(),
'projectId' => $this->project->getId(),
'schedule' => $document->getAttribute('schedule'),
'active' => !empty($document->getAttribute('schedule')) && !empty($document->getAttribute('deployment')),
]));
$document->setAttribute('scheduleId', $schedule->getId());
$document->setAttribute('scheduleInternalId', $schedule->getInternalId());
if ($document->getAttribute('schedule') && !$document->getAttribute('scheduleId', null)) {
$schedule = $this->consoleDB->createDocument('schedules', new Document([
'region' => App::getEnv('_APP_REGION', 'default'), // Todo replace with projects region
'resourceType' => 'function',
'resourceId' => $document->getId(),
'resourceInternalId' => $document->getInternalId(),
'resourceUpdatedAt' => DateTime::now(),
'projectId' => $this->project->getId(),
'schedule' => $document->getAttribute('schedule'),
'active' => !empty($document->getAttribute('schedule')) && !empty($document->getAttribute('deployment')),
]));
$document->setAttribute('scheduleId', $schedule->getId());
$document->setAttribute('scheduleInternalId', $schedule->getInternalId());
}
break;
case 'projects':
$document->setAttribute('version', '1.4.0');