1
0
Fork 0
mirror of synced 2024-07-03 21:50:34 +12:00

PR review changes

This commit is contained in:
Matej Bačo 2022-08-30 08:57:10 +00:00
parent 56282fb2fa
commit b8f6393df6
6 changed files with 8 additions and 15 deletions

8
composer.lock generated
View file

@ -2841,12 +2841,12 @@
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/appwrite/sdk-generator.git", "url": "https://github.com/appwrite/sdk-generator.git",
"reference": "bf05fc00755b9d27dac530669ca834f3ceb655ec" "reference": "6e630a62f522ac68a7056bebf81cd032c7a053ba"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/appwrite/sdk-generator/zipball/bf05fc00755b9d27dac530669ca834f3ceb655ec", "url": "https://api.github.com/repos/appwrite/sdk-generator/zipball/6e630a62f522ac68a7056bebf81cd032c7a053ba",
"reference": "bf05fc00755b9d27dac530669ca834f3ceb655ec", "reference": "6e630a62f522ac68a7056bebf81cd032c7a053ba",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -2884,7 +2884,7 @@
"issues": "https://github.com/appwrite/sdk-generator/issues", "issues": "https://github.com/appwrite/sdk-generator/issues",
"source": "https://github.com/appwrite/sdk-generator/tree/master" "source": "https://github.com/appwrite/sdk-generator/tree/master"
}, },
"time": "2022-08-28T04:14:32+00:00" "time": "2022-08-29T10:43:33+00:00"
}, },
{ {
"name": "doctrine/instantiator", "name": "doctrine/instantiator",

View file

@ -114,6 +114,7 @@ class Queries extends Validator
return true; return true;
} }
/** /**
* Is array * Is array
* *

View file

@ -54,15 +54,6 @@ abstract class Base extends Validator
return self::TYPE_OBJECT; return self::TYPE_OBJECT;
} }
/**
* Is valid.
*
* @param Query $value
*
* @return bool
*/
abstract public function isValid($query): bool;
/** /**
* Returns what type of query this Validator is for * Returns what type of query this Validator is for
*/ */

View file

@ -16,7 +16,7 @@ class LimitTest extends TestCase
public function setUp(): void public function setUp(): void
{ {
$this->validator = new Limit(); $this->validator = new Limit(100);
} }
public function tearDown(): void public function tearDown(): void

View file

@ -16,7 +16,7 @@ class OffsetTest extends TestCase
public function setUp(): void public function setUp(): void
{ {
$this->validator = new Offset(); $this->validator = new Offset(5000);
} }
public function tearDown(): void public function tearDown(): void

View file

@ -50,5 +50,6 @@ class OrderTest extends TestCase
$this->assertEquals($this->validator->isValid(Query::equal('dne', ['v'])), false, $this->validator->getDescription()); $this->assertEquals($this->validator->isValid(Query::equal('dne', ['v'])), false, $this->validator->getDescription());
$this->assertEquals($this->validator->isValid(Query::equal('', ['v'])), false, $this->validator->getDescription()); $this->assertEquals($this->validator->isValid(Query::equal('', ['v'])), false, $this->validator->getDescription());
$this->assertEquals($this->validator->isValid(Query::orderDesc('dne')), false, $this->validator->getDescription()); $this->assertEquals($this->validator->isValid(Query::orderDesc('dne')), false, $this->validator->getDescription());
$this->assertEquals($this->validator->isValid(Query::orderAsc('dne')), false, $this->validator->getDescription());
} }
} }