1
0
Fork 0
mirror of synced 2024-10-01 01:37:56 +13:00

review changes

This commit is contained in:
prateek banga 2023-11-20 16:21:06 +05:30
parent 5c1cf3a526
commit b1eaf97806
2 changed files with 7 additions and 12 deletions

View file

@ -1673,14 +1673,11 @@ App::post('/v1/messaging/topics/:topicId/subscribers')
->setParam('topicId', $topic->getId())
->setParam('subscriberId', $subscriber->getId());
$subscriber->setAttribute('userName', $user->getAttribute('name'));
$response
->setStatusCode(Response::STATUS_CODE_CREATED)
->dynamic(
$subscriber
->setAttribute('userId', $user->getId())
->setAttribute('userName', $user->getAttribute('name')),
Response::MODEL_SUBSCRIBER
);
->dynamic($subscriber, Response::MODEL_SUBSCRIBER);
});
App::get('/v1/messaging/topics/:topicId/subscribers')
@ -1856,12 +1853,10 @@ App::get('/v1/messaging/topics/:topicId/subscribers/:subscriberId')
$user = Authorization::skip(fn () => $dbForProject->getDocument('users', $subscriber->getAttribute('userId')));
$subscriber->setAttribute('userName', $user->getAttribute('name'));
$response
->dynamic(
$subscriber
->setAttribute('userName', $user->getAttribute('name')),
Response::MODEL_SUBSCRIBER
);
->dynamic($subscriber, Response::MODEL_SUBSCRIBER);
});
App::delete('/v1/messaging/topics/:topicId/subscribers/:subscriberId')

View file

@ -38,7 +38,7 @@ class Subscriber extends Model
'type' => self::TYPE_STRING,
'description' => 'User ID.',
'default' => '',
'example' => '259125845563242502',
'example' => '5e5ea5c16897e',
])
->addRule('userName', [
'type' => self::TYPE_STRING,