CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-06-02 19:04:49 +12:00
Code Issues Projects Releases Wiki Activity

Update docs/tutorials/add-runtime.md

Browse source 
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
This commit is contained in:
Bradley Schofield 2021-10-08 09:13:56 +01:00 committed by GitHub
parent 03605bd097
commit ab2c2686df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/tutorials/add-runtime.md
View file

@ -225,7 +225,7 @@ Once you have done this and saved it, it is finally time to move onto one of the
### 5.4 Running the tests.
Running the tests is easy, simply run `docker-compose up` in the root of the `php-runtimes` folder. This will launch a Docker container with the test script and start running through all the runtimes making sure to test them thoroughly.
If all tests pass then congratulations! You can now go ahead and file a PR against the `php-runtimes` repo, make sure your ready to respond to any feedback which can arise during our code review.
If all tests pass then congratulations! You can now go ahead and file a PR against the `php-runtimes` repo, make sure you're ready to respond to any feedback which can arise during our code review.
## 6. Raise a pull request
First of all, commit the changes with the message `Added XXX Runtime` and push it. This will publish a new branch to your forked version of Appwrite. If you visit it at `github.com/YOUR_USERNAME/php-runtimes`, you will see a new alert saying you are ready to submit a pull request. Follow the steps GitHub provides, and at the end, you will have your pull request submitted.