fix(messaging): use count of delivery errors for metrics
`$deliveryErrors` is an array so we need to get a count before using it in metrics.
This commit is contained in:
parent
154993dafd
commit
9c088f974a
1 changed files with 7 additions and 7 deletions
|
@ -287,18 +287,18 @@ class Messaging extends Action
|
||||||
} catch (\Throwable $e) {
|
} catch (\Throwable $e) {
|
||||||
$deliveryErrors[] = 'Failed sending to targets with error: ' . $e->getMessage();
|
$deliveryErrors[] = 'Failed sending to targets with error: ' . $e->getMessage();
|
||||||
} finally {
|
} finally {
|
||||||
|
$errorTotal = count($deliveryErrors);
|
||||||
$queueForUsage
|
$queueForUsage
|
||||||
->setProject($project)
|
->setProject($project)
|
||||||
->addMetric(METRIC_MESSAGES, ($deliveredTotal + $deliveryErrors))
|
->addMetric(METRIC_MESSAGES, ($deliveredTotal + $errorTotal))
|
||||||
->addMetric(METRIC_MESSAGES_SENT, $deliveredTotal)
|
->addMetric(METRIC_MESSAGES_SENT, $deliveredTotal)
|
||||||
->addMetric(METRIC_MESSAGES_FAILED, $deliveryErrors)
|
->addMetric(METRIC_MESSAGES_FAILED, $errorTotal)
|
||||||
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE), ($deliveredTotal + $deliveryErrors))
|
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE), ($deliveredTotal + $errorTotal))
|
||||||
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE_SENT), $deliveredTotal)
|
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE_SENT), $deliveredTotal)
|
||||||
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE_FAILED), $deliveryErrors)
|
->addMetric(str_replace('{type}', $provider->getAttribute('type'), METRIC_MESSAGES_TYPE_FAILED), $errorTotal)
|
||||||
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER), ($deliveredTotal + $deliveryErrors))
|
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER), ($deliveredTotal + $errorTotal))
|
||||||
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER_SENT), $deliveredTotal)
|
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER_SENT), $deliveredTotal)
|
||||||
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER_FAILED), $deliveryErrors)
|
->addMetric(str_replace(['{type}', '{provider}'], [$provider->getAttribute('type'), $this->getSmsAdapter($provider)], METRIC_MESSAGES_TYPE_PROVIDER_FAILED), $errorTotal)
|
||||||
->trigger();
|
->trigger();
|
||||||
|
|
||||||
return [
|
return [
|
||||||
|
|
Loading…
Reference in a new issue