Merge branch 'dev' of github.com:appwrite/appwrite into feat-set-default-permissions-to-user

CHANGES.md

@@ -6,6 +6,12 @@
 
 - Upgraded ClamAV to version 1.3.0
 
+# Version 0.7.2 (Not Released Yet)
+
+## Bugs
+
+- Fixed certificates worker error on successful operations
+
 # Version 0.7.1
 
 ## Features

app/controllers/api/functions.php

@@ -435,7 +435,7 @@ App::post('/v1/functions/:functionId/tags')
     ->label('sdk.response.model', Response::MODEL_TAG)
     ->param('functionId', '', new UID(), 'Function unique ID.')
     ->param('command', '', new Text('1028'), 'Code execution command.')
-    ->param('code', null, new File(), 'Gzip file with your code package. When used with the Appwrite CLI, pass the path to your code directory, and the CLI will automatically package your code. Use a path that is within the current directory.', false)
+    ->param('code', [], new File(), 'Gzip file with your code package. When used with the Appwrite CLI, pass the path to your code directory, and the CLI will automatically package your code. Use a path that is within the current directory.', false)
     ->inject('request')
     ->inject('response')
     ->inject('projectDB')

app/workers/certificates.php

@@ -124,7 +124,7 @@ class CertificatesV1
             ." -w ".APP_STORAGE_CERTIFICATES
             ." -d {$domain->get()}", '', $stdout, $stderr);
 
-        if($stderr || $exit !== 0) {
+        if($exit !== 0) {
             throw new Exception('Failed to issue a certificate with message: '.$stderr);
         }
 

tests/e2e/Services/Functions/FunctionsCustomServerTest.php

@@ -628,7 +628,7 @@ class FunctionsCustomServerTest extends Scope
             ], $this->getHeaders()), [
                 'tag' => $tagId,
             ]);
-    
+
             $this->assertEquals(200, $tag['headers']['status-code']);
            
             $execution = $this->client->call(Client::METHOD_POST, '/functions/'.$functionId.'/executions', array_merge([