1
0
Fork 0
mirror of synced 2024-06-26 10:10:57 +12:00

Markdown syntax fix, Extend suggestions from code review

This commit is contained in:
Matej Baco 2021-08-30 10:14:53 +02:00
parent 5d7d1fc006
commit 70a906c3b6
2 changed files with 4 additions and 4 deletions

View file

@ -42,7 +42,7 @@ app/config/providers.php
Make sure to fill in all data needed and that your provider array key name:
- is in [camelCase](https://en.wikipedia.org/wiki/Camel_case) format
- is in [`camelCase`](https://en.wikipedia.org/wiki/Camel_case) format
- has no spaces or special characters
> Please make sure to keep the list of providers in `providers.php` in the alphabetical order A-Z.
@ -56,7 +56,7 @@ Add a logo image to your new provider in this path: `public/images/users`. Your
Once you have finished setting up all the metadata for the new provider, you need to start coding.
Create a new file `XXX.php` where `XXX` is the name of the OAuth provider in [`PascalCase`](https://stackoverflow.com/a/41769355/7659504) in this location
"`bash
```bash
src/Appwrite/Auth/OAuth2/XXX.php
```
@ -64,7 +64,7 @@ Inside this file, create a new class that extends the basic OAuth2 provider abst
Once a new class is created, you can start to implement your new provider's login flow. We have prepared a starting point for Oauth provider class below, but you should also consider looking at other provider's implementation and try to follow the same standards.
```injectablephp
```php
<?php
namespace Appwrite\Auth\OAuth2;

View file

@ -176,7 +176,7 @@ If you can see countries names translated, everything works, and you are ready f
## 5. Raise a pull request
First of all, commit the changes with the message `Added YYY translations` where `YYY` is the translated language and push it. This will publish a new branch to your forked version of Appwrite. If you visit it at `github.com/YOUR_USERNAME_appwrite`, you will see a new alert saying you are ready to submit a pull request. Follow the steps GitHub provides, and at the end, you will have your pull request submitted.
First of all, commit the changes with the message `Added YYY translations` where `YYY` is the translated language and push it. This will publish a new branch to your forked version of Appwrite. If you visit it at `github.com/YOUR_USERNAME/appwrite`, you will see a new alert saying you are ready to submit a pull request. Follow the steps GitHub provides, and at the end, you will have your pull request submitted.
## 🤕 Stuck ?
If you need any help with the contribution, feel free to head over to [our discord channel](https://appwrite.io/discord) and we'll be happy to help you out.