1
0
Fork 0
mirror of synced 2024-10-03 19:53:33 +13:00

feat: review comments

This commit is contained in:
Christy Jacob 2023-08-08 16:47:51 +00:00
parent 882698d6e4
commit 5b42d2c21f
2 changed files with 38 additions and 37 deletions

View file

@ -697,7 +697,7 @@ foreach ($locales as $locale) {
if (!\file_exists($path)) { if (!\file_exists($path)) {
$path = __DIR__ . '/config/locale/translations/' . \substr($code, 0, 2) . '.json'; // if `ar-ae` doesn't exist, look for `ar` $path = __DIR__ . '/config/locale/translations/' . \substr($code, 0, 2) . '.json'; // if `ar-ae` doesn't exist, look for `ar`
if (!\file_exists($path)) { if (!\file_exists($path)) {
// var_dump('Unable to find translations for ' . $locale['code'] . ' so using en.json'); Console::warning('Unable to find translations for ' . $locale['code'] . ' so using en.json');
$path = __DIR__ . '/config/locale/translations/en.json'; // if none translation exists, use default from `en.json` $path = __DIR__ . '/config/locale/translations/en.json'; // if none translation exists, use default from `en.json`
} }
} }

73
composer.lock generated
View file

@ -607,16 +607,16 @@
}, },
{ {
"name": "guzzlehttp/promises", "name": "guzzlehttp/promises",
"version": "2.0.0", "version": "2.0.1",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/guzzle/promises.git", "url": "https://github.com/guzzle/promises.git",
"reference": "3a494dc7dc1d7d12e511890177ae2d0e6c107da6" "reference": "111166291a0f8130081195ac4556a5587d7f1b5d"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/guzzle/promises/zipball/3a494dc7dc1d7d12e511890177ae2d0e6c107da6", "url": "https://api.github.com/repos/guzzle/promises/zipball/111166291a0f8130081195ac4556a5587d7f1b5d",
"reference": "3a494dc7dc1d7d12e511890177ae2d0e6c107da6", "reference": "111166291a0f8130081195ac4556a5587d7f1b5d",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -670,7 +670,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/guzzle/promises/issues", "issues": "https://github.com/guzzle/promises/issues",
"source": "https://github.com/guzzle/promises/tree/2.0.0" "source": "https://github.com/guzzle/promises/tree/2.0.1"
}, },
"funding": [ "funding": [
{ {
@ -686,20 +686,20 @@
"type": "tidelift" "type": "tidelift"
} }
], ],
"time": "2023-05-21T13:50:22+00:00" "time": "2023-08-03T15:11:55+00:00"
}, },
{ {
"name": "guzzlehttp/psr7", "name": "guzzlehttp/psr7",
"version": "2.5.0", "version": "2.6.0",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/guzzle/psr7.git", "url": "https://github.com/guzzle/psr7.git",
"reference": "b635f279edd83fc275f822a1188157ffea568ff6" "reference": "8bd7c33a0734ae1c5d074360512beb716bef3f77"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/guzzle/psr7/zipball/b635f279edd83fc275f822a1188157ffea568ff6", "url": "https://api.github.com/repos/guzzle/psr7/zipball/8bd7c33a0734ae1c5d074360512beb716bef3f77",
"reference": "b635f279edd83fc275f822a1188157ffea568ff6", "reference": "8bd7c33a0734ae1c5d074360512beb716bef3f77",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -786,7 +786,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/guzzle/psr7/issues", "issues": "https://github.com/guzzle/psr7/issues",
"source": "https://github.com/guzzle/psr7/tree/2.5.0" "source": "https://github.com/guzzle/psr7/tree/2.6.0"
}, },
"funding": [ "funding": [
{ {
@ -802,7 +802,7 @@
"type": "tidelift" "type": "tidelift"
} }
], ],
"time": "2023-04-17T16:11:26+00:00" "time": "2023-08-03T15:06:02+00:00"
}, },
{ {
"name": "influxdb/influxdb-php", "name": "influxdb/influxdb-php",
@ -3783,16 +3783,16 @@
}, },
{ {
"name": "phpstan/phpdoc-parser", "name": "phpstan/phpdoc-parser",
"version": "1.22.1", "version": "1.23.1",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/phpstan/phpdoc-parser.git", "url": "https://github.com/phpstan/phpdoc-parser.git",
"reference": "65c39594fbd8c67abfc68bb323f86447bab79cc0" "reference": "846ae76eef31c6d7790fac9bc399ecee45160b26"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/phpstan/phpdoc-parser/zipball/65c39594fbd8c67abfc68bb323f86447bab79cc0", "url": "https://api.github.com/repos/phpstan/phpdoc-parser/zipball/846ae76eef31c6d7790fac9bc399ecee45160b26",
"reference": "65c39594fbd8c67abfc68bb323f86447bab79cc0", "reference": "846ae76eef31c6d7790fac9bc399ecee45160b26",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -3824,22 +3824,22 @@
"description": "PHPDoc parser with support for nullable, intersection and generic types", "description": "PHPDoc parser with support for nullable, intersection and generic types",
"support": { "support": {
"issues": "https://github.com/phpstan/phpdoc-parser/issues", "issues": "https://github.com/phpstan/phpdoc-parser/issues",
"source": "https://github.com/phpstan/phpdoc-parser/tree/1.22.1" "source": "https://github.com/phpstan/phpdoc-parser/tree/1.23.1"
}, },
"time": "2023-06-29T20:46:06+00:00" "time": "2023-08-03T16:32:59+00:00"
}, },
{ {
"name": "phpunit/php-code-coverage", "name": "phpunit/php-code-coverage",
"version": "9.2.26", "version": "9.2.27",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/sebastianbergmann/php-code-coverage.git", "url": "https://github.com/sebastianbergmann/php-code-coverage.git",
"reference": "443bc6912c9bd5b409254a40f4b0f4ced7c80ea1" "reference": "b0a88255cb70d52653d80c890bd7f38740ea50d1"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/443bc6912c9bd5b409254a40f4b0f4ced7c80ea1", "url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/b0a88255cb70d52653d80c890bd7f38740ea50d1",
"reference": "443bc6912c9bd5b409254a40f4b0f4ced7c80ea1", "reference": "b0a88255cb70d52653d80c890bd7f38740ea50d1",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -3895,7 +3895,8 @@
], ],
"support": { "support": {
"issues": "https://github.com/sebastianbergmann/php-code-coverage/issues", "issues": "https://github.com/sebastianbergmann/php-code-coverage/issues",
"source": "https://github.com/sebastianbergmann/php-code-coverage/tree/9.2.26" "security": "https://github.com/sebastianbergmann/php-code-coverage/security/policy",
"source": "https://github.com/sebastianbergmann/php-code-coverage/tree/9.2.27"
}, },
"funding": [ "funding": [
{ {
@ -3903,7 +3904,7 @@
"type": "github" "type": "github"
} }
], ],
"time": "2023-03-06T12:58:08+00:00" "time": "2023-07-26T13:44:30+00:00"
}, },
{ {
"name": "phpunit/php-file-iterator", "name": "phpunit/php-file-iterator",
@ -4755,16 +4756,16 @@
}, },
{ {
"name": "sebastian/global-state", "name": "sebastian/global-state",
"version": "5.0.5", "version": "5.0.6",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/sebastianbergmann/global-state.git", "url": "https://github.com/sebastianbergmann/global-state.git",
"reference": "0ca8db5a5fc9c8646244e629625ac486fa286bf2" "reference": "bde739e7565280bda77be70044ac1047bc007e34"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/sebastianbergmann/global-state/zipball/0ca8db5a5fc9c8646244e629625ac486fa286bf2", "url": "https://api.github.com/repos/sebastianbergmann/global-state/zipball/bde739e7565280bda77be70044ac1047bc007e34",
"reference": "0ca8db5a5fc9c8646244e629625ac486fa286bf2", "reference": "bde739e7565280bda77be70044ac1047bc007e34",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -4807,7 +4808,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/sebastianbergmann/global-state/issues", "issues": "https://github.com/sebastianbergmann/global-state/issues",
"source": "https://github.com/sebastianbergmann/global-state/tree/5.0.5" "source": "https://github.com/sebastianbergmann/global-state/tree/5.0.6"
}, },
"funding": [ "funding": [
{ {
@ -4815,7 +4816,7 @@
"type": "github" "type": "github"
} }
], ],
"time": "2022-02-14T08:28:10+00:00" "time": "2023-08-02T09:26:13+00:00"
}, },
{ {
"name": "sebastian/lines-of-code", "name": "sebastian/lines-of-code",
@ -5578,16 +5579,16 @@
}, },
{ {
"name": "twig/twig", "name": "twig/twig",
"version": "v3.6.1", "version": "v3.7.0",
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/twigphp/Twig.git", "url": "https://github.com/twigphp/Twig.git",
"reference": "7e7d5839d4bec168dfeef0ac66d5c5a2edbabffd" "reference": "5cf942bbab3df42afa918caeba947f1b690af64b"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/twigphp/Twig/zipball/7e7d5839d4bec168dfeef0ac66d5c5a2edbabffd", "url": "https://api.github.com/repos/twigphp/Twig/zipball/5cf942bbab3df42afa918caeba947f1b690af64b",
"reference": "7e7d5839d4bec168dfeef0ac66d5c5a2edbabffd", "reference": "5cf942bbab3df42afa918caeba947f1b690af64b",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
@ -5633,7 +5634,7 @@
], ],
"support": { "support": {
"issues": "https://github.com/twigphp/Twig/issues", "issues": "https://github.com/twigphp/Twig/issues",
"source": "https://github.com/twigphp/Twig/tree/v3.6.1" "source": "https://github.com/twigphp/Twig/tree/v3.7.0"
}, },
"funding": [ "funding": [
{ {
@ -5645,7 +5646,7 @@
"type": "tidelift" "type": "tidelift"
} }
], ],
"time": "2023-06-08T12:52:13+00:00" "time": "2023-07-26T07:16:09+00:00"
} }
], ],
"aliases": [], "aliases": [],