fix: review comments
This commit is contained in:
parent
2f944e9abc
commit
5689353994
|
@ -203,7 +203,7 @@ App::post('/v1/runtimes')
|
|||
'-f',
|
||||
'/dev/null'
|
||||
];
|
||||
|
||||
|
||||
$containerId = $orchestration->run(
|
||||
image: $baseImage,
|
||||
name: $runtimeId,
|
||||
|
@ -548,7 +548,7 @@ App::error(function ($utopia, $error, $request, $response) {
|
|||
'file' => $error->getFile(),
|
||||
'line' => $error->getLine(),
|
||||
'trace' => $error->getTrace(),
|
||||
'version' => App::getEnv('OPENRUNTIMES_VERSION', 'UNKNOWN'),
|
||||
'version' => App::getEnv('_APP_VERSION', 'UNKNOWN')
|
||||
];
|
||||
|
||||
$response
|
||||
|
|
|
@ -393,7 +393,6 @@ services:
|
|||
- VERSION=dev
|
||||
networks:
|
||||
appwrite:
|
||||
runtimes:
|
||||
ports:
|
||||
- 9519:80
|
||||
volumes:
|
||||
|
@ -497,10 +496,6 @@ services:
|
|||
- _APP_INFLUXDB_HOST
|
||||
- _APP_INFLUXDB_PORT
|
||||
- _APP_USAGE_SYNC_INTERVAL
|
||||
- _APP_REDIS_HOST
|
||||
- _APP_REDIS_PORT
|
||||
- _APP_REDIS_USER
|
||||
- _APP_REDIS_PASS
|
||||
|
||||
appwrite-schedule:
|
||||
entrypoint: schedule
|
||||
|
@ -677,7 +672,6 @@ services:
|
|||
networks:
|
||||
gateway:
|
||||
appwrite:
|
||||
runtimes:
|
||||
|
||||
volumes:
|
||||
appwrite-mariadb:
|
||||
|
|
|
@ -59,7 +59,7 @@ class Executor
|
|||
'baseImage' => $baseImage,
|
||||
'entrypoint' => $entrypoint,
|
||||
'workdir' => $workdir,
|
||||
'network' => empty($network) ? App::getEnv('_APP_EXECUTOR_RUNTIME_NETWORK', 'openruntimes') : $network,
|
||||
'network' => empty($network) ? App::getEnv('_APP_EXECUTOR_RUNTIME_NETWORK', 'appwrite_runtimes') : $network,
|
||||
'vars' => $vars,
|
||||
'remove' => $remove,
|
||||
'commands' => $commands
|
||||
|
|
Loading…
Reference in a new issue