CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-06-29 19:50:26 +12:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2830 from appwrite/feat-functions-deprecate-sync-model

Browse source 
Remove Synchronous execution model
This commit is contained in:
Christy Jacob 2022-02-24 18:21:16 +04:00 committed by GitHub
parent 55a4bf3dcc b2217f6950
commit 5059e67d72
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/controllers/api/functions.php
View file

@ -967,11 +967,10 @@ App::post('/v1/functions/:functionId/executions')
}
Authorization::skip(fn() => $dbForProject->updateDocument('executions', $executionId, $execution));
$executionResponse['response'] = ($executionResponse['status'] !== 'completed') ? $executionResponse['stderr'] : $executionResponse['stdout'];
$response
->setStatusCode(Response::STATUS_CODE_CREATED)
->dynamic(new Document($executionResponse), Response::MODEL_SYNC_EXECUTION);
->dynamic($execution, Response::MODEL_EXECUTION);
});
App::get('/v1/functions/:functionId/executions')

3
src/Appwrite/Utopia/Response.php
View file

@ -31,7 +31,6 @@ use Appwrite\Utopia\Response\Model\Domain;
use Appwrite\Utopia\Response\Model\Error;
use Appwrite\Utopia\Response\Model\ErrorDev;
use Appwrite\Utopia\Response\Model\Execution;
use Appwrite\Utopia\Response\Model\SyncExecution;
use Appwrite\Utopia\Response\Model\Build;
use Appwrite\Utopia\Response\Model\File;
use Appwrite\Utopia\Response\Model\Bucket;
@ -156,7 +155,6 @@ class Response extends SwooleResponse
const MODEL_DEPLOYMENT = 'deployment';
const MODEL_DEPLOYMENT_LIST = 'deploymentList';
const MODEL_EXECUTION = 'execution';
const MODEL_SYNC_EXECUTION = 'syncExecution';
const MODEL_EXECUTION_LIST = 'executionList';
const MODEL_BUILD = 'build';
const MODEL_BUILD_LIST = 'buildList';
@ -268,7 +266,6 @@ class Response extends SwooleResponse
->setModel(new Runtime())
->setModel(new Deployment())
->setModel(new Execution())
->setModel(new SyncExecution())
->setModel(new Build())
->setModel(new Project())
->setModel(new Webhook())

53
src/Appwrite/Utopia/Response/Model/SyncExecution.php
View file

@ -1,53 +0,0 @@
<?php
namespace Appwrite\Utopia\Response\Model;
use Appwrite\Utopia\Response;
use Appwrite\Utopia\Response\Model;
class SyncExecution extends Model
{
public function __construct()
{
$this
->addRule('status', [
'type' => self::TYPE_STRING,
'description' => 'Execution Status.',
'default' => '',
'example' => 'completed',
])
->addRule('response', [
'type' => self::TYPE_STRING,
'description' => 'Execution Response.',
'default' => '',
'example' => 'Hello World!',
])
->addRule('time', [
'type' => self::TYPE_INTEGER,
'description' => 'Execution Time.',
'default' => 0,
'example' => 100,
])
;
}
/**
* Get Name
*
* @return string
*/
public function getName():string
{
return 'Syncronous Execution';
}
/**
* Get Collection
*
* @return string
*/
public function getType():string
{
return Response::MODEL_SYNC_EXECUTION;
}
}