CodeMirror/appwrite
1
0
Fork 0
mirror of synced 2024-06-29 19:50:26 +12:00
Code Issues Projects Releases Wiki Activity

feat: fix failing tests

Browse source
This commit is contained in:
Christy Jacob 2022-01-27 03:19:02 +04:00
parent 9e33960d95
commit 2c91a24928
4 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/controllers/api/functions.php
View file

@ -367,7 +367,7 @@ App::patch('/v1/functions/:functionId/deployment')
$function = $dbForProject->getDocument('functions', $functionId); $function = $dbForProject->getDocument('functions', $functionId);
$deployment = $dbForProject->getDocument('deployments', $deployment); $deployment = $dbForProject->getDocument('deployments', $deployment);
$build = $dbForProject->getDocument('builds', $deployment->getAttribute('buildId')); $build = $dbForProject->getDocument('builds', $deployment->getAttribute('buildId', ''));
if ($function->isEmpty()) { if ($function->isEmpty()) {
throw new Exception('Function not found', 404); throw new Exception('Function not found', 404);
@ -924,8 +924,8 @@ App::post('/v1/functions/:functionId/executions')
\curl_close($ch); \curl_close($ch);
$response $response
->setStatusCode(Response::STATUS_CODE_CREATED) ->setStatusCode(Response::STATUS_CODE_CREATED)
->dynamic(new Document(json_decode($responseExecute, true)), Response::MODEL_SYNC_EXECUTION); ->dynamic(new Document(json_decode($responseExecute, true)), Response::MODEL_SYNC_EXECUTION);
}); });
App::get('/v1/functions/:functionId/executions') App::get('/v1/functions/:functionId/executions')

13
app/executor.php
View file

@ -930,15 +930,10 @@ App::post('/v1/functions/:functionId/executions')
->inject('dbForProject') ->inject('dbForProject')
->action( ->action(
function (string $trigger, string $projectId, string $executionId, string $functionId, string $event, string $eventData, string $data, array $webhooks, string $userId, string $jwt, Response $response, Database $dbForProject) { function (string $trigger, string $projectId, string $executionId, string $functionId, string $event, string $eventData, string $data, array $webhooks, string $userId, string $jwt, Response $response, Database $dbForProject) {
try { $data = execute($trigger, $projectId, $executionId, $functionId, $dbForProject, $event, $eventData, $data, $webhooks, $userId, $jwt);
$data = execute($trigger, $projectId, $executionId, $functionId, $dbForProject, $event, $eventData, $data, $webhooks, $userId, $jwt); $response
$response ->setStatusCode(Response::STATUS_CODE_OK)
->setStatusCode(Response::STATUS_CODE_OK) ->json($data);
->json($data);
} catch (Exception $e) {
logError($e, 'executeEndpoint');
throw $e;
}
} }
); );

1
app/workers/builds.php
View file

@ -151,7 +151,6 @@ class BuildsV1 extends Worker
// Build the Code // Build the Code
try { try {
Console::info("[ INFO ] Creating build with id: $buildId");
$deployment->setAttribute('status', 'building'); $deployment->setAttribute('status', 'building');
$deployment = $dbForProject->updateDocument('deployments', $deploymentId, $deployment); $deployment = $dbForProject->updateDocument('deployments', $deploymentId, $deployment);
$this->createBuild($projectId, $functionId, $deploymentId, $buildId); $this->createBuild($projectId, $functionId, $deploymentId, $buildId);

2
tests/e2e/Services/Functions/FunctionsCustomClientTest.php
View file

@ -242,7 +242,7 @@ class FunctionsCustomClientTest extends Scope
'content-type' => 'application/json', 'content-type' => 'application/json',
'x-appwrite-project' => $this->getProject()['$id'], 'x-appwrite-project' => $this->getProject()['$id'],
], [ ], [
'async' => 1, 'async' => true,
]); ]);
$this->assertEquals(401, $execution['headers']['status-code']); $this->assertEquals(401, $execution['headers']['status-code']);