some fixes for pylint

.github/workflows/tests.yml

@@ -81,5 +81,5 @@ jobs:
           pip install -r requirements.txt
       - name: Analysing the code with pylint
         run: |
-          pylint rare --disable=R,C,E0611,I1101,W1203,W1201,W0201 --ignore=ui,singleton.py,json_formatter.py --extension-pkg-whitelist=PyQt5
+          pylint -E rare --disable=E0611 --ignore=ui,singleton.py --extension-pkg-whitelist=PyQt5
 

rare/__main__.py

@@ -10,8 +10,14 @@ from rare.utils import singleton
 
 
 def main():
-    # CLI Options
+    # fix cx_freeze
+    import multiprocessing
+    multiprocessing.freeze_support()
 
+    # insert legendary submodule to path
+    sys.path.insert(0, os.path.join(pathlib.Path(__file__).parent.parent.absolute(), "legendary"))
+
+    # CLI Options
     parser = ArgumentParser()
     parser.add_argument("-V", "--version", action="store_true", help="Shows version and exits")
     parser.add_argument("-S", "--silent", action="store_true",
@@ -64,9 +70,4 @@ def main():
 
 
 if __name__ == '__main__':
-    # fix error in cx_freeze
-    import multiprocessing
-
-    multiprocessing.freeze_support()
-    sys.path.insert(0, os.path.join(pathlib.Path(__file__).parent.parent.absolute(), "legendary"))
     main()

rare/components/tabs/cloud_saves/__init__.py

@@ -1,7 +1,7 @@
 from logging import getLogger
 
 from PyQt5.QtCore import QThread, pyqtSignal, Qt
-from PyQt5.QtWidgets import *
+from PyQt5.QtWidgets import QScrollArea, QWidget, QVBoxLayout, QLabel, QPushButton, QMessageBox
 
 from legendary.core import LegendaryCore
 from legendary.models.game import SaveGameStatus

rare/components/tabs/downloads/dl_queue_widget.py

@@ -95,7 +95,7 @@ class DlQueueWidget(QGroupBox):
                 self.dl_queue.pop(index)
                 break
         else:
-            logger.warning("BUG! ", app_name)
+            logger.warning("BUG! " + app_name)
             return
         self.update_list.emit(self.dl_queue)
         self.update_queue(self.dl_queue)