CodeMirror/Rare
1
0
Fork 0
mirror of synced 2024-06-26 10:11:19 +12:00
Code Issues Projects Releases Wiki Activity

Do not create a worker for every request

Browse source
This commit is contained in:
Dummerle 2021-12-12 00:25:21 +01:00
parent a7f3f3c325
commit 7d600f8d34
No known key found for this signature in database
GPG key ID: AB68CC59CA39F2F1
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
rare/components/dialogs/launch_dialog.py
View file

@ -34,19 +34,23 @@ class ImageWorker(QRunnable):
class ApiRequestWorker(QRunnable):
def __init__(self, api_requests: list):
def __init__(self):
super(ApiRequestWorker, self).__init__()
self.api_requests = api_requests
self.signals = ApiSignals()
self.setAutoDelete(True)
def run(self) -> None:
for text, function, args in self.api_requests:
try:
result = function(*args)
except HTTPError():
result = None
self.signals.result.emit(result, text)
try:
result = shared.core.get_game_and_dlc_list(True, "Mac")
except HTTPError():
result = [], {}
self.signals.result.emit(result, "mac")
try:
result = shared.core.get_game_and_dlc_list(True, "Win32")
except HTTPError():
result = [], {}
self.signals.result.emit(result, "32bit")
class AssetWorker(QRunnable):
@ -124,12 +128,8 @@ class LaunchDialog(QDialog, Ui_LaunchDialog):
image_worker.signal.result.connect(self.handle_api_worker_result)
self.thread_pool.start(image_worker)
api_requests = [
["32bit", self.core.get_game_and_dlc_list, (True, "Win32")],
["mac", self.core.get_game_and_dlc_list, (True, "Mac")],
]
# gamelist and no_asset games are from Image worker
worker = ApiRequestWorker(api_requests)
worker = ApiRequestWorker()
worker.signals.result.connect(self.handle_api_worker_result)
self.thread_pool.start(worker)