Fix wrong origin classification for ue plugins without assets

rare/components/tabs/games/__init__.py

@@ -5,13 +5,13 @@ from PyQt5.QtCore import QSettings, Qt, pyqtSlot
 from PyQt5.QtWidgets import QStackedWidget, QVBoxLayout, QWidget, QScrollArea, QFrame
 from legendary.models.game import InstalledGame, Game
 
+from rare.shared import ImageManagerSingleton
 from rare.shared import (
     LegendaryCoreSingleton,
     GlobalSignalsSingleton,
     ArgumentsSingleton,
     ApiResultsSingleton,
 )
-from rare.shared import ImageManagerSingleton
 from rare.widgets.library_layout import LibraryLayout
 from rare.widgets.sliding_stack import SlidingStackedWidget
 from .cloud_save_utils import CloudSaveUtils
@@ -37,7 +37,7 @@ class GamesTab(QStackedWidget):
     running_games = list()
     updates = set()
     active_filter = 0
-    uninstalled_games = None
+    uninstalled_games: List[Game] = []
 
     def __init__(self, parent=None):
         super(GamesTab, self).__init__(parent=parent)
@@ -224,14 +224,16 @@ class GamesTab(QStackedWidget):
             self.list_view.layout().addWidget(list_widget)
 
         for game in self.no_assets:
-            icon_widget, list_widget = self.add_installed_widget(game.app_name)
+            if not game.metadata.get("customAttributes", {}).get("ThirdPartyManagedApp", {}).get("value") == "Origin":
+                icon_widget, list_widget = self.add_uninstalled_widget(game)
+            else:
+                icon_widget, list_widget = self.add_installed_widget(game.app_name)
             if not icon_widget or not list_widget:
                 logger.warning(f"Ignoring {game.app_name} in game list")
                 continue
             self.icon_view.layout().addWidget(icon_widget)
             self.list_view.layout().addWidget(list_widget)
 
-        self.uninstalled_games = []
         for game in sorted(self.game_list, key=lambda x: x.app_title):
             if not self.core.is_installed(game.app_name):
                 self.uninstalled_games.append(game)
@@ -330,8 +332,8 @@ class GamesTab(QStackedWidget):
                 visible = True
 
             if (
-                search_text.lower() not in widget.game.app_name.lower()
-                and search_text.lower() not in widget.game.app_title.lower()
+                    search_text.lower() not in widget.game.app_name.lower()
+                    and search_text.lower() not in widget.game.app_title.lower()
             ):
                 opacity = 0.25
             else:
@@ -365,7 +367,8 @@ class GamesTab(QStackedWidget):
                 )
             )
         self.icon_view.layout().insert(0, installing_widget)
-        list_widgets = self.list_view.findChildren(InstalledListWidget) + self.list_view.findChildren(UninstalledListWidget)
+        list_widgets = self.list_view.findChildren(InstalledListWidget) + self.list_view.findChildren(
+            UninstalledListWidget)
         if sort_by:
             list_widgets.sort(key=lambda x: (sort_by not in x.game.app_title.lower(),))
         else:

rare/components/tabs/games/game_widgets/base_installed_widget.py

@@ -38,7 +38,8 @@ class BaseInstalledWidget(QFrame):
                 "launch": self.tr("Launch Game"),
                 "launch_origin": self.tr("Launch/Link"),
                 "running": self.tr("Game running"),
-                "launch_offline": self.tr("Launch offline")
+                "launch_offline": self.tr("Launch offline"),
+                "no_launch": self.tr("Can't launch game")
             },
             "default": {
                 "running": self.tr("Game running"),
@@ -232,6 +233,10 @@ class BaseInstalledWidget(QFrame):
         """
         return not self.game.asset_infos
 
+    @property
+    def is_origin(self) -> bool:
+        return self.game.metadata.get("customAttributes", {}).get("ThirdPartyManagedApp", {}).get("value") == "Origin"
+
     @property
     def is_installed(self) -> bool:
         """!

rare/components/tabs/games/game_widgets/installed_icon_widget.py

@@ -88,7 +88,7 @@ class InstalledIconWidget(BaseInstalledWidget):
             self.info_label.setText(self.texts["hover"]["update_available"])
         else:
             self.info_label.setText(
-                self.texts["hover"]["launch" if self.igame else "launch_origin"]
+                self.texts["hover"]["launch" if self.igame else "launch_origin" if self.is_origin else "no_launch"]
             )
 
     def leaveEvent(self, a0: QEvent = None) -> None:

rare/components/tabs/games/game_widgets/installed_list_widget.py

@@ -29,7 +29,7 @@ class InstalledListWidget(BaseInstalledWidget):
         self.setLayout(self.layout)
         self.layout.addWidget(self.image)
 
-        ##Layout on the right
+        # Layout on the right
         self.childLayout = QVBoxLayout()
         self.layout.addLayout(self.childLayout)
 
@@ -39,8 +39,13 @@ class InstalledListWidget(BaseInstalledWidget):
         self.childLayout.addWidget(self.title_label)
         self.app_name_label = QLabel(self.game.app_name)
         self.launch_button = QPushButton(
-            play_icon, self.tr("Launch") if self.igame else self.tr("Link/Play")
+            play_icon,
+            self.tr("Launch") if self.igame else self.tr("Link/Play") if self.is_origin else self.texts["hover"][
+                "no_launch"]
         )
+        if not self.is_origin and not self.igame:
+            self.launch_button.setDisabled(True)
+
         self.launch_button.setObjectName("launch_game_button")
         self.launch_button.setFixedWidth(150)