CodeMirror/xpipe
1
0
Fork 0
mirror of https://github.com/xpipe-io/xpipe.git synced 2024-07-02 21:11:03 +12:00
Code Issues Packages Projects Releases Wiki Activity

Fix show details action failing for windows root drives

Browse source
This commit is contained in:
crschnick 2023-07-11 06:59:39 +00:00
parent d1216811c8
commit 4048e3b730
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
ext/base/src/main/java/io/xpipe/ext/base/browser/OpenNativeFileDetailsAction.java
View file

@ -22,16 +22,24 @@ public class OpenNativeFileDetailsAction implements LeafAction {
var e = entry.getRawFileEntry().getPath(); var e = entry.getRawFileEntry().getPath();
switch (OsType.getLocal()) { switch (OsType.getLocal()) {
case OsType.Windows windows -> { case OsType.Windows windows -> {
var content = String.format( var parent = FileNames.getParent(e);
""" // If we execute this on a drive root there will be no parent, so we have to check for that!
$shell = New-Object -ComObject Shell.Application; $shell.NameSpace('%s').ParseName('%s').InvokeVerb('Properties') var content = parent != null
""", ? String.format(
FileNames.getParent(e), FileNames.getFileName(e)); "$shell = New-Object -ComObject Shell.Application; $shell.NameSpace('%s').ParseName('%s').InvokeVerb('Properties')",
FileNames.getParent(e), FileNames.getFileName(e))
: String.format(
"$shell = New-Object -ComObject Shell.Application; $shell.NameSpace('%s').Self.InvokeVerb('Properties')",
e);
// The Windows shell invoke verb functionality behaves kinda weirdly and only shows the window as long as the parent process is running. // The Windows shell invoke verb functionality behaves kinda weirdly and only shows the window as
// long as the parent process is running.
// So let's keep one process running // So let's keep one process running
if (powershell == null) { if (powershell == null) {
powershell = new LocalStore().control().subShell(ShellDialects.POWERSHELL).start(); powershell = new LocalStore()
.control()
.subShell(ShellDialects.POWERSHELL)
.start();
} }
powershell.command(content).notComplex().execute(); powershell.command(content).notComplex().execute();