1
0
Fork 0
mirror of https://github.com/gorhill/uMatrix.git synced 2024-06-14 00:05:08 +12:00

code review re #118

This commit is contained in:
gorhill 2015-03-12 09:28:02 -04:00
parent 390733affe
commit df27e666a7

View file

@ -200,19 +200,12 @@ vAPI.tabs.open = function(details) {
return;
}
chrome.tabs.query({}, function(tabs) {
var rgxHash = /#.*/;
// this is questionable
var url = targetURL.replace(rgxHash, '');
var selected = tabs.some(function(tab) {
if ( tab.url.replace(rgxHash, '') === url ) {
chrome.tabs.update(tab.id, { active: true });
chrome.windows.update(tab.windowId, { focused: true });
return true;
}
});
if ( !selected ) {
chrome.tabs.query({ url: targetURL }, function(tabs) {
var tab = tabs[0];
if ( tab ) {
chrome.windows.update(tab.windowId, { focused: true });
chrome.tabs.update(tab.id, { active: true });
} else {
wrapper();
}
});