From 8c8a1685b2740bb4c9ea0695b38aa020947927d7 Mon Sep 17 00:00:00 2001 From: Philipp Heckel Date: Tue, 8 Mar 2022 21:18:15 -0500 Subject: [PATCH] Fix it --- web/src/components/App.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/web/src/components/App.js b/web/src/components/App.js index 0c69a017..5104d205 100644 --- a/web/src/components/App.js +++ b/web/src/components/App.js @@ -136,14 +136,17 @@ const useConnectionListeners = () => { }; const useAutoSubscribe = (subscriptions, selected) => { - const [autoSubscribed, setAutoSubscribed] = useState(false); + const [hasRun, setHasRun] = useState(false); const params = useParams(); useEffect(() => { const loaded = subscriptions !== null && subscriptions !== undefined; - const eligible = loaded && params.topic && !selected && !autoSubscribed; + if (!loaded || hasRun) { + return; + } + setHasRun(true); + const eligible = params.topic && !selected; if (eligible) { - setAutoSubscribed(true); const baseUrl = (params.baseUrl) ? expandSecureUrl(params.baseUrl) : window.location.origin; console.log(`[App] Auto-subscribing to ${topicUrl(baseUrl, params.topic)}`); (async () => { @@ -151,7 +154,7 @@ const useAutoSubscribe = (subscriptions, selected) => { poller.pollInBackground(subscription); // Dangle! })(); } - }, [params, subscriptions, selected, autoSubscribed]); + }, [params, subscriptions, selected, hasRun]); }; const updateTitle = (newNotificationsCount) => {