From 5f6d753cb7e9ba2814a5760be463874206e737ab Mon Sep 17 00:00:00 2001 From: nimbleghost <132819643+nimbleghost@users.noreply.github.com> Date: Mon, 19 Jun 2023 21:45:55 +0200 Subject: [PATCH] Remove navigation fallback for all except app root --- server/server.go | 2 -- web/public/sw.js | 8 -------- 2 files changed, 10 deletions(-) diff --git a/server/server.go b/server/server.go index e684992b..4ae85ebb 100644 --- a/server/server.go +++ b/server/server.go @@ -77,8 +77,6 @@ var ( authPathRegex = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}(,[-_A-Za-z0-9]{1,64})*/auth$`) publishPathRegex = regexp.MustCompile(`^/[-_A-Za-z0-9]{1,64}/(publish|send|trigger)$`) - // Note: new paths that should be viewable directly in the browser should be added to web/public/sw.js's navigation fallback denyList as well - webConfigPath = "/config.js" webManifestPath = "/manifest.webmanifest" webRootHTMLPath = "/app.html" diff --git a/web/public/sw.js b/web/public/sw.js index 4585b38f..d3967441 100644 --- a/web/public/sw.js +++ b/web/public/sw.js @@ -241,15 +241,7 @@ if (!import.meta.env.DEV) { allowlist: [ // the app root itself, could be /, or not new RegExp(`^${config.app_root}$`), - // any route starting with `/`, but not `/` itself. - // this is so we don't respond to `/` UNLESS it's the app root itself, defined above - /^\/.+$/, ], - // only /docs, /file and /v1 are required so they are navigable in the browser (files for clicking on attachments, - // v1 for the redirect from Stripe). The rest are nice-to-haves so the single-page-app doesn't try to handle them, - // but `fetch` and browser requests would work anyway – they are mainly there so inspecting them is easier than - // calling the URLs via curl. - denylist: [/^\/(docs|file|v1|metrics|static|_matrix).*$/, /^\/(app.html|manifest.webmanifest|sw.js|config.js)$/], }) );