diff --git a/CHANGELOG.md b/CHANGELOG.md index 19321df..6711db6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,10 +7,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +## [1.0.1] - 2018-11-29 + +### Fixed + ++ Removed unnecessary `VOLUME` declaration in `Dockerfile` + + see [this article](https://boxboat.com/2017/01/23/volumes-and-dockerfiles-dont-mix/) + ## 1.0.0 - 2018-11-29 ### Added + Initial release -[Unreleased]: https://github.com/mserajnik/hydrus-server-docker/compare/1.0.0...develop +[Unreleased]: https://github.com/mserajnik/hydrus-server-docker/compare/1.0.1...develop +[1.0.1]: https://github.com/mserajnik/hydrus-server-docker/compare/1.0.0...1.0.1 diff --git a/Dockerfile b/Dockerfile index 2e25f4a..8d78dc8 100644 --- a/Dockerfile +++ b/Dockerfile @@ -29,8 +29,6 @@ RUN rm $(ls | grep "Linux.-.Executable.tar.gz") \ RUN mkdir /data && chown -R hydrus:hydrus /data -VOLUME /data - COPY docker-entrypoint.sh /usr/local/bin/docker-entrypoint RUN chmod +x /usr/local/bin/docker-entrypoint diff --git a/README.md b/README.md index c7a6696..7e7fa99 100644 --- a/README.md +++ b/README.md @@ -67,13 +67,6 @@ versions. ## Usage -hydrus-server-docker mounts a volume on `/data` that is used to store the -databases and media. It is highly recommended to create a named volume: - -```zsh -user@local:~$ docker volume create hydrus-server-data -``` - Likewise, you need to bind the exposed ports. This can be done automatically using `-P` but it is recommended to bind them manually instead since having changing ports every time you run a new container might be annoying when used @@ -90,7 +83,17 @@ for the server administration service while `45871` and `45872` are used for repositories. You will generally have two (one for tags and one for files), but if you add more, you will also need to expose additional ports. -After creating your named volume, you can run the container: +Per default, hydrus-server-docker stores its databases and media inside the +`/data` directory. It is highly recommended to create a named volume and mount +it to the same location if you wish to persist the data beyond the lifetime of +the container and/or access it on the host: + +```zsh +user@local:~$ docker volume create hydrus-server-data +``` + +After creating your named volume, you can run the container. Here is a full +example with all the options mentioned above: ```zsh user@local:~$ docker run -p 45870:45870 -p 45871:45871 -p 45872:45872 -v hydrus-server-data:/data -d mserajnik/hydrus-server-docker