From 16772b1c52e7e79d621c006724327dad49bf3dee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafa=C5=82=20Mikrut?= <mikrutrafal@protonmail.com>
Date: Thu, 25 Nov 2021 11:15:31 +0100
Subject: [PATCH] Update Mac installation instruction add info about Chocolatey

---
 czkawka_gui/src/saving_loading.rs |  3 +--
 instructions/Compilation.md       |  9 +++++++--
 instructions/Installation.md      | 10 ++++++++--
 3 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/czkawka_gui/src/saving_loading.rs b/czkawka_gui/src/saving_loading.rs
index 2da788d..74efeeb 100644
--- a/czkawka_gui/src/saving_loading.rs
+++ b/czkawka_gui/src/saving_loading.rs
@@ -9,8 +9,7 @@ use std::io::Write;
 use std::path::Path;
 use std::{env, fs};
 
-// TODO add more settings, maybe to different dialog window
-
+// TODO organize this better, add specific functions that will allow to load from files specific strings
 const SAVE_FILE_NAME: &str = "czkawka_gui_config.txt";
 
 pub fn save_configuration(manual_execution: bool, upper_notebook: &GuiUpperNotebook, settings: &GuiSettings, text_view_errors: &TextView) {
diff --git a/instructions/Compilation.md b/instructions/Compilation.md
index 517cd80..25f3cf0 100644
--- a/instructions/Compilation.md
+++ b/instructions/Compilation.md
@@ -22,12 +22,12 @@ sudo yum install gtk3-devel glib2-devel alsa-lib-devel # Latest is optional
 ```
 
 #### macOS
-You need to install Rust via Homebrew and GTK Libraries
+You need to install Rust via Homebrew and GTK Libraries(ffmpeg is optional dependency)
 ```shell
 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
 brew install rustup
 rustup-init
-brew install rust gtk+3
+brew install rust gtk+3 adwaita-icon-theme librsvg ffmpeg
 ```
 
 ### Windows
@@ -43,6 +43,11 @@ After that the latest GTK 3 runtime must be installed from https://github.com/ts
 
 ## Compilation
 
+Czkawka can be installed with Debug or Release build.  
+With Debug build additional checks e.g. for variables overflow are available but depends of the usage it works very slow so should be using only to develop this app.    
+Compilation with `--release` flag will optimize binaries, so they can be used with good performance(official binaries are build with this flag)
+
+
 - Download the source
 ```
 git clone https://github.com/qarmin/czkawka.git
diff --git a/instructions/Installation.md b/instructions/Installation.md
index e3ee622..21576f3 100644
--- a/instructions/Installation.md
+++ b/instructions/Installation.md
@@ -23,12 +23,12 @@ sudo xbps-install gcc pkg-config alsa-lib-devel ffpmeg
 ```
 
 ### macOS
-Currently, you need to manually install `GTK 3` libraries, `FFmpeg` and the Adwaita theme, because they are dynamically loaded from the OS (*help in linking statically these things is needed*).  
+Currently, you need to manually install `GTK 3` libraries, `FFmpeg` and the Adwaita theme, because they are dynamically loaded from the OS.  
 One very straight-forward way to do this is by using [Homebrew](https://brew.sh/).  
 Installation in the terminal:
 ```shell
 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
-brew install gtk+3 adwaita-icon-theme ffmpeg
+brew install gtk+3 adwaita-icon-theme ffmpeg librsvg
 ```
 After that, go to the location where you downloaded Czkawka and add the `executable` permission to this file.
 ```shell
@@ -39,6 +39,9 @@ At the end execute it:
 ./mac_czkawka_gui
 ```
 
+**Warning**  
+If you use want to use app on ARM machine e.g. Mac M1, you can't use prebuilt binaries, because they were compiled for x86_64 architecture. You need to compile Czkawka manually to get proper binaries.
+
 ### Windows
 By default, all needed libraries are bundled with the app, inside `windows_czkawka_gui.zip`, but if you compile the app or just move `czkawka_gui.exe`, then you will need to install the `GTK 3`
 runtime from [**here**](https://github.com/tschoonj/GTK-for-Windows-Runtime-Environment-Installer/releases).
@@ -119,3 +122,6 @@ Package info's - https://aur.archlinux.org/packages/?O=0&SeB=nd&K=czkawka&outdat
 
 ### Docker image (unofficial)
 Czkawka docker image is available [**here**](https://github.com/jlesage/docker-czkawka)
+
+### Chocolatey (unofficial)
+Windows Chocolatey binaries are available [**here**](https://community.chocolatey.org/packages/czkawka)
\ No newline at end of file