CodeMirror/bulk-downloader-for-reddit
1
0
Fork 0
mirror of synced 2024-05-13 08:42:47 +12:00
Code Issues Releases Wiki Activity

Merge pull request #496 from Serene-Arc/bug_fix_495

Browse source 
Fix bug with deleted galleries
This commit is contained in:
Serene 2021-07-19 18:46:42 +10:00 committed by GitHub
parent 8826fc5aa9 77aaee96f3
commit b58eebb51f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bdfr/site_downloaders/gallery.py
View file

@ -21,7 +21,7 @@ class Gallery(BaseDownloader):
def find_resources(self, authenticator: Optional[SiteAuthenticator] = None) -> list[Resource]:
try:
image_urls = self._get_links(self.post.gallery_data['items'])
except AttributeError:
except (AttributeError, TypeError):
try:
image_urls = self._get_links(self.post.crosspost_parent_list[0]['gallery_data']['items'])
except (AttributeError, IndexError, TypeError):

11
tests/site_downloaders/test_gallery.py
View file

@ -4,6 +4,7 @@
import praw
import pytest
from bdfr.exceptions import SiteDownloaderError
from bdfr.site_downloaders.gallery import Gallery
@ -68,3 +69,13 @@ def test_gallery_download(test_submission_id: str, expected_hashes: set[str], re
[res.download(120) for res in results]
hashes = [res.hash.hexdigest() for res in results]
assert set(hashes) == expected_hashes
@pytest.mark.parametrize('test_id', (
'n0pyzp',
))
def test_gallery_download_raises_right_error(test_id: str, reddit_instance: praw.Reddit):
test_submission = reddit_instance.submission(id=test_id)
gallery = Gallery(test_submission)
with pytest.raises(SiteDownloaderError):
gallery.find_resources()