From fca31849502ed933e9abe70c555a58048c9623de Mon Sep 17 00:00:00 2001 From: BlipRanger <1860540+BlipRanger@users.noreply.github.com> Date: Wed, 12 May 2021 10:47:33 -0400 Subject: [PATCH 1/7] Bind socket to '0.0.0.0' rather than 'localhost' to allow for more flexible OAuth connection. (#368) --- bdfr/oauth2.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bdfr/oauth2.py b/bdfr/oauth2.py index 6b27599..bd60c9b 100644 --- a/bdfr/oauth2.py +++ b/bdfr/oauth2.py @@ -70,8 +70,8 @@ class OAuth2Authenticator: def receive_connection() -> socket.socket: server = socket.socket(socket.AF_INET, socket.SOCK_STREAM) server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) - server.bind(('localhost', 7634)) - logger.log(9, 'Server listening on localhost:7634') + server.bind(('0.0.0.0', 7634)) + logger.log(9, 'Server listening on 0.0.0.0:7634') server.listen(1) client = server.accept()[0] From 8a7d21e159cbb70ee62c557d5a2fb2cebcb885a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ali=20Parlak=C3=A7=C4=B1?= Date: Sat, 15 May 2021 12:13:42 +0300 Subject: [PATCH 2/7] Create build artifact (#372) * Create build artifact * Update publish.yml --- .github/workflows/publish.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 1a679d1..6f15a00 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -27,3 +27,9 @@ jobs: run: | python setup.py sdist bdist_wheel twine upload dist/* + + - name: Upload coverage report + uses: actions/upload-artifact@v2 + with: + name: dist + path: dist/ From aea30d2b44f6099645a70341ba508f853c167e23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ali=20Parlak=C3=A7=C4=B1?= Date: Sat, 15 May 2021 13:11:01 +0300 Subject: [PATCH 3/7] Check if REDDIT_TOKEN is set (#376) --- devscripts/configure.ps1 | 7 +++++-- devscripts/configure.sh | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/devscripts/configure.ps1 b/devscripts/configure.ps1 index 8ac0ce1..b096266 100644 --- a/devscripts/configure.ps1 +++ b/devscripts/configure.ps1 @@ -1,2 +1,5 @@ -copy .\\bdfr\\default_config.cfg .\\test_config.cfg -echo "`nuser_token = $env:REDDIT_TOKEN" >> ./test_config.cfg \ No newline at end of file +if (-not ([string]::IsNullOrEmpty($env:REDDIT_TOKEN))) +{ + copy .\\bdfr\\default_config.cfg .\\test_config.cfg + echo "`nuser_token = $env:REDDIT_TOKEN" >> ./test_config.cfg +} \ No newline at end of file diff --git a/devscripts/configure.sh b/devscripts/configure.sh index 48e7c3e..d9c96df 100755 --- a/devscripts/configure.sh +++ b/devscripts/configure.sh @@ -1,2 +1,5 @@ -cp ./bdfr/default_config.cfg ./test_config.cfg -echo -e "\nuser_token = $REDDIT_TOKEN" >> ./test_config.cfg \ No newline at end of file +if [ ! -z "$REDDIT_TOKEN" ] +then + cp ./bdfr/default_config.cfg ./test_config.cfg + echo -e "\nuser_token = $REDDIT_TOKEN" >> ./test_config.cfg +fi \ No newline at end of file From c7a5ec43768a64e6e9bfe8cf1438626363ab6426 Mon Sep 17 00:00:00 2001 From: Ali Parlakci Date: Sat, 15 May 2021 14:35:16 +0300 Subject: [PATCH 4/7] bug(youtube.dl): Fix crash on zero downloads #375 --- bdfr/site_downloaders/youtube.py | 9 +++++++-- tests/site_downloaders/test_youtube.py | 16 +++++++++++++++- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/bdfr/site_downloaders/youtube.py b/bdfr/site_downloaders/youtube.py index 482d4bc..e12fdc1 100644 --- a/bdfr/site_downloaders/youtube.py +++ b/bdfr/site_downloaders/youtube.py @@ -8,7 +8,7 @@ from typing import Optional import youtube_dl from praw.models import Submission -from bdfr.exceptions import SiteDownloaderError +from bdfr.exceptions import (NotADownloadableLinkError, SiteDownloaderError) from bdfr.resource import Resource from bdfr.site_authenticator import SiteAuthenticator from bdfr.site_downloaders.base_downloader import BaseDownloader @@ -43,7 +43,12 @@ class Youtube(BaseDownloader): except youtube_dl.DownloadError as e: raise SiteDownloaderError(f'Youtube download failed: {e}') - downloaded_file = list(download_path.iterdir())[0] + downloaded_file = None + downloaded_files = list(download_path.iterdir()) + if len(downloaded_files) > 0: + downloaded_file = downloaded_files[0] + else: + raise NotADownloadableLinkError(f"No media exists in the URL {self.post.url}") extension = downloaded_file.suffix with open(downloaded_file, 'rb') as file: content = file.read() diff --git a/tests/site_downloaders/test_youtube.py b/tests/site_downloaders/test_youtube.py index 95bf1ea..90b451a 100644 --- a/tests/site_downloaders/test_youtube.py +++ b/tests/site_downloaders/test_youtube.py @@ -5,6 +5,7 @@ from unittest.mock import MagicMock import pytest +from bdfr.exceptions import NotADownloadableLinkError from bdfr.resource import Resource from bdfr.site_downloaders.youtube import Youtube @@ -15,7 +16,7 @@ from bdfr.site_downloaders.youtube import Youtube ('https://www.youtube.com/watch?v=uSm2VDgRIUs', 'f70b704b4b78b9bb5cd032bfc26e4971'), ('https://www.youtube.com/watch?v=m-tKnjFwleU', '30314930d853afff8ebc7d8c36a5b833'), )) -def test_find_resources(test_url: str, expected_hash: str): +def test_find_resources_good(test_url: str, expected_hash: str): test_submission = MagicMock() test_submission.url = test_url downloader = Youtube(test_submission) @@ -24,3 +25,16 @@ def test_find_resources(test_url: str, expected_hash: str): assert isinstance(resources[0], Resource) resources[0].download(120) assert resources[0].hash.hexdigest() == expected_hash + + +@pytest.mark.online +@pytest.mark.slow +@pytest.mark.parametrize(('test_url'), ( + ('https://www.polygon.com/disney-plus/2020/5/14/21249881/gargoyles-animated-series-disney-plus-greg-weisman-interview-oj-simpson-goliath-chronicles'), +)) +def test_find_resources_bad(test_url: str): + test_submission = MagicMock() + test_submission.url = test_url + downloader = Youtube(test_submission) + with pytest.raises(NotADownloadableLinkError): + downloader.find_resources() From 17226a4f0beafe96514bd7bf3dff7698ef77ff98 Mon Sep 17 00:00:00 2001 From: Ali Parlakci Date: Sat, 15 May 2021 14:37:47 +0300 Subject: [PATCH 5/7] refactor(youtube.dl): Remove slow parameter --- tests/site_downloaders/test_youtube.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/site_downloaders/test_youtube.py b/tests/site_downloaders/test_youtube.py index 90b451a..986b0db 100644 --- a/tests/site_downloaders/test_youtube.py +++ b/tests/site_downloaders/test_youtube.py @@ -28,7 +28,6 @@ def test_find_resources_good(test_url: str, expected_hash: str): @pytest.mark.online -@pytest.mark.slow @pytest.mark.parametrize(('test_url'), ( ('https://www.polygon.com/disney-plus/2020/5/14/21249881/gargoyles-animated-series-disney-plus-greg-weisman-interview-oj-simpson-goliath-chronicles'), )) From ef37712115fc02cb768388580d005402d7fe13ee Mon Sep 17 00:00:00 2001 From: alpbetgam <84060801+alpbetgam@users.noreply.github.com> Date: Sun, 16 May 2021 14:16:47 +1200 Subject: [PATCH 6/7] Fix error with old gfycat/redgifs urls --- bdfr/site_downloaders/gfycat.py | 1 + tests/site_downloaders/test_gfycat.py | 1 + 2 files changed, 2 insertions(+) diff --git a/bdfr/site_downloaders/gfycat.py b/bdfr/site_downloaders/gfycat.py index eb33620..6accaab 100644 --- a/bdfr/site_downloaders/gfycat.py +++ b/bdfr/site_downloaders/gfycat.py @@ -27,6 +27,7 @@ class Gfycat(Redgifs): response = Gfycat.retrieve_url(url) if re.search(r'(redgifs|gifdeliverynetwork)', response.url): + url = url.lower() # Fixes error with old gfycat/redgifs links return Redgifs._get_link(url) soup = BeautifulSoup(response.text, 'html.parser') diff --git a/tests/site_downloaders/test_gfycat.py b/tests/site_downloaders/test_gfycat.py index 78c37a3..56aa2d0 100644 --- a/tests/site_downloaders/test_gfycat.py +++ b/tests/site_downloaders/test_gfycat.py @@ -14,6 +14,7 @@ from bdfr.site_downloaders.gfycat import Gfycat ('https://gfycat.com/definitivecaninecrayfish', 'https://giant.gfycat.com/DefinitiveCanineCrayfish.mp4'), ('https://gfycat.com/dazzlingsilkyiguana', 'https://giant.gfycat.com/DazzlingSilkyIguana.mp4'), ('https://gfycat.com/webbedimpurebutterfly', 'https://thumbs2.redgifs.com/WebbedImpureButterfly.mp4'), + ('https://gfycat.com/CornyLoathsomeHarrierhawk', 'https://thumbs2.redgifs.com/CornyLoathsomeHarrierhawk.mp4') )) def test_get_link(test_url: str, expected_url: str): result = Gfycat._get_link(test_url) From 739f97edcce9097cade4f57931da2c3a5e1a41fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ali=20Parlak=C3=A7=C4=B1?= Date: Sun, 16 May 2021 13:28:48 +0300 Subject: [PATCH 7/7] Bump the version to 2.1.1 --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index 1bba6b1..b1345d9 100644 --- a/setup.cfg +++ b/setup.cfg @@ -4,7 +4,7 @@ description_file = README.md description_content_type = text/markdown home_page = https://github.com/aliparlakci/bulk-downloader-for-reddit keywords = reddit, download, archive -version = 2.1.0 +version = 2.1.1 author = Ali Parlakci author_email = parlakciali@gmail.com maintainer = Serene Arc