1
0
Fork 0
mirror of synced 2024-05-05 21:02:38 +12:00

Fix xml archiver encoding bug (#349)

* test_integration: add archiver tests

* archiver.py: fix encoding bug in xml archiver
This commit is contained in:
Ali Parlakçı 2021-05-06 16:11:48 +03:00 committed by GitHub
parent 4ab1d6d6e0
commit a2e22e894a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions

View file

@ -89,7 +89,7 @@ class Archiver(RedditDownloader):
def _write_content_to_disk(self, resource: Resource, content: str):
file_path = self.file_name_formatter.format_path(resource, self.download_directory)
file_path.parent.mkdir(exist_ok=True, parents=True)
with open(file_path, 'w') as file:
with open(file_path, 'w', encoding="utf-8") as file:
logger.debug(
f'Writing entry {resource.source_submission.id} to file in {resource.extension[1:].upper()}'
f' format at {file_path}')

View file

@ -196,7 +196,8 @@ def test_cli_download_long(test_args: list[str], tmp_path: Path):
@pytest.mark.skipif(not does_test_config_exist, reason='A test config file is required for integration tests')
@pytest.mark.parametrize('test_args', (
['-l', 'gstd4hk'],
['-l', 'm2601g'],
['-l', 'm2601g', '-f', 'yaml'],
['-l', 'n60t4c', '-f', 'xml'],
))
def test_cli_archive_single(test_args: list[str], tmp_path: Path):
runner = CliRunner()