Add exception for r/all in subreddit check
This commit is contained in:
parent
14195157de
commit
711f8b0c76
2 changed files with 16 additions and 1 deletions
|
@ -468,6 +468,8 @@ class RedditDownloader:
|
||||||
|
|
||||||
@staticmethod
|
@staticmethod
|
||||||
def _check_subreddit_status(subreddit: praw.models.Subreddit):
|
def _check_subreddit_status(subreddit: praw.models.Subreddit):
|
||||||
|
if subreddit.display_name == 'all':
|
||||||
|
return
|
||||||
try:
|
try:
|
||||||
assert subreddit.id
|
assert subreddit.id
|
||||||
except prawcore.NotFound:
|
except prawcore.NotFound:
|
||||||
|
|
|
@ -513,7 +513,20 @@ def test_check_user_existence_banned(
|
||||||
('donaldtrump', 'cannot be found'),
|
('donaldtrump', 'cannot be found'),
|
||||||
('submitters', 'private and cannot be scraped')
|
('submitters', 'private and cannot be scraped')
|
||||||
))
|
))
|
||||||
def test_check_subreddit_status(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit):
|
def test_check_subreddit_status_bad(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit):
|
||||||
test_subreddit = reddit_instance.subreddit(test_subreddit_name)
|
test_subreddit = reddit_instance.subreddit(test_subreddit_name)
|
||||||
with pytest.raises(BulkDownloaderException, match=expected_message):
|
with pytest.raises(BulkDownloaderException, match=expected_message):
|
||||||
RedditDownloader._check_subreddit_status(test_subreddit)
|
RedditDownloader._check_subreddit_status(test_subreddit)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.online
|
||||||
|
@pytest.mark.reddit
|
||||||
|
@pytest.mark.parametrize('test_subreddit_name', (
|
||||||
|
'Python',
|
||||||
|
'Mindustry',
|
||||||
|
'TrollXChromosomes',
|
||||||
|
'all',
|
||||||
|
))
|
||||||
|
def test_check_subreddit_status_good(test_subreddit_name: str, reddit_instance: praw.Reddit):
|
||||||
|
test_subreddit = reddit_instance.subreddit(test_subreddit_name)
|
||||||
|
RedditDownloader._check_subreddit_status(test_subreddit)
|
||||||
|
|
Loading…
Reference in a new issue