CodeMirror/bulk-downloader-for-reddit
1
0
Fork 0
mirror of synced 2024-06-10 22:34:40 +12:00
Code Issues Releases Wiki Activity

Add exception for r/all in subreddit check

Browse source
This commit is contained in:
Serene-Arc 2021-05-02 13:59:45 +10:00 committed by Serene
parent 14195157de
commit 711f8b0c76
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bdfr/downloader.py
View file

@ -468,6 +468,8 @@ class RedditDownloader:
@staticmethod
def _check_subreddit_status(subreddit: praw.models.Subreddit):
if subreddit.display_name == 'all':
return
try:
assert subreddit.id
except prawcore.NotFound:

15
tests/test_downloader.py
View file

@ -513,7 +513,20 @@ def test_check_user_existence_banned(
('donaldtrump', 'cannot be found'),
('submitters', 'private and cannot be scraped')
))
def test_check_subreddit_status(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit):
def test_check_subreddit_status_bad(test_subreddit_name: str, expected_message: str, reddit_instance: praw.Reddit):
test_subreddit = reddit_instance.subreddit(test_subreddit_name)
with pytest.raises(BulkDownloaderException, match=expected_message):
RedditDownloader._check_subreddit_status(test_subreddit)
@pytest.mark.online
@pytest.mark.reddit
@pytest.mark.parametrize('test_subreddit_name', (
'Python',
'Mindustry',
'TrollXChromosomes',
'all',
))
def test_check_subreddit_status_good(test_subreddit_name: str, reddit_instance: praw.Reddit):
test_subreddit = reddit_instance.subreddit(test_subreddit_name)
RedditDownloader._check_subreddit_status(test_subreddit)