CodeMirror/bulk-downloader-for-reddit
1
0
Fork 0
mirror of synced 2024-04-28 17:32:34 +12:00
Code Issues Releases Wiki Activity

Merge pull request #520 from elipsitz/fix-imgur-download-mp4

Browse source
This commit is contained in:
Serene 2021-09-13 20:05:47 +10:00 committed by GitHub
parent 063caf0126 33312687ac
commit 668fe80127
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bdfr/site_downloaders/imgur.py
View file

@ -32,7 +32,11 @@ class Imgur(BaseDownloader):
return out
def _compute_image_url(self, image: dict) -> Resource:
image_url = 'https://i.imgur.com/' + image['hash'] + self._validate_extension(image['ext'])
ext = self._validate_extension(image['ext'])
if image.get('prefer_video', False):
ext = '.mp4'
image_url = 'https://i.imgur.com/' + image['hash'] + ext
return Resource(self.post, image_url, Resource.retry_download(image_url))
@staticmethod

10
tests/site_downloaders/test_imgur.py
View file

@ -111,7 +111,7 @@ def test_imgur_extension_validation_bad(test_extension: str):
),
(
'https://imgur.com/gallery/IjJJdlC',
('7227d4312a9779b74302724a0cfa9081',),
('740b006cf9ec9d6f734b6e8f5130bdab',),
),
(
'https://imgur.com/a/dcc84Gt',
@ -142,6 +142,14 @@ def test_imgur_extension_validation_bad(test_extension: str):
'https://imgur.com/ubYwpbk.GIFV',
('d4a774aac1667783f9ed3a1bd02fac0c',),
),
(
'https://i.imgur.com/j1CNCZY.gifv',
('58e7e6d972058c18b7ecde910ca147e3',),
),
(
'https://i.imgur.com/uTvtQsw.gifv',
('46c86533aa60fc0e09f2a758513e3ac2',),
),
))
def test_find_resources(test_url: str, expected_hashes: list[str]):
mock_download = Mock()