Tweak regex to fix incorrect match (#237)
This commit is contained in:
parent
5d86c2d400
commit
44889d5264
|
@ -44,7 +44,7 @@ class DownloadFactory:
|
|||
return Youtube
|
||||
elif re.match(url_beginning + r'i\.redd\.it.*', url):
|
||||
return Direct
|
||||
elif re.match(url_beginning + r'.*\..{3,4}$', url):
|
||||
elif re.match(url_beginning + r'.*/.*\.\w{3,4}$', url):
|
||||
return Direct
|
||||
else:
|
||||
raise NotADownloadableLinkError('No downloader module exists for url {}'.format(url))
|
||||
|
|
|
@ -46,6 +46,10 @@ def test_factory_lever_good(test_submission_id: str, expected_class: BaseDownloa
|
|||
@pytest.mark.parametrize('test_url', (
|
||||
'random.com',
|
||||
'bad',
|
||||
'https://www.google.com/',
|
||||
'https://www.google.com',
|
||||
'https://www.google.com/test',
|
||||
'https://www.google.com/test/',
|
||||
))
|
||||
def test_factory_lever_bad(test_url: str):
|
||||
with pytest.raises(NotADownloadableLinkError):
|
||||
|
|
Loading…
Reference in a new issue