From 3e9a846e2e5ecc36e049e32c57a8032ffd9d1282 Mon Sep 17 00:00:00 2001 From: Serene-Arc Date: Wed, 17 Mar 2021 16:27:26 +1000 Subject: [PATCH] Refactor Reddit Gallery tests --- .../tests/downloaders/test_gallery.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/bulkredditdownloader/tests/downloaders/test_gallery.py b/bulkredditdownloader/tests/downloaders/test_gallery.py index 2b29a4b..222bb52 100644 --- a/bulkredditdownloader/tests/downloaders/test_gallery.py +++ b/bulkredditdownloader/tests/downloaders/test_gallery.py @@ -1,22 +1,22 @@ #!/usr/bin/env python3 # coding=utf-8 -import praw.models +import praw import pytest from bulkredditdownloader.resource import Resource from bulkredditdownloader.site_downloaders.gallery import Gallery -@pytest.fixture() -def reddit_submission(reddit_instance) -> praw.models.Submission: - return reddit_instance.submission(id='ljyy27') - - @pytest.mark.online @pytest.mark.reddit -def test_gallery(reddit_submission: praw.models.Submission): - gallery = Gallery(reddit_submission) +@pytest.mark.parametrize(('test_submission_id', 'expected_len'), ( + ('ljyy27', 4), + ('m6lvrh', 4), +)) +def test_gallery(test_submission_id: str, expected_len: int, reddit_instance: praw.Reddit): + test_submission = reddit_instance.submission(id=test_submission_id) + gallery = Gallery(test_submission) results = gallery.find_resources() - assert len(results) == 4 + assert len(results) == expected_len assert all([isinstance(result, Resource) for result in results])