Move logfiles into configuration directory on OS
This commit is contained in:
parent
6d6327a396
commit
3e18997652
2 changed files with 3 additions and 7 deletions
|
@ -119,11 +119,10 @@ class RedditDownloader:
|
||||||
|
|
||||||
def _determine_directories(self):
|
def _determine_directories(self):
|
||||||
self.download_directory = Path(self.args.directory).resolve().expanduser()
|
self.download_directory = Path(self.args.directory).resolve().expanduser()
|
||||||
self.logfile_directory = self.download_directory / 'LOG_FILES'
|
self.config_directory = Path(self.config_directories.user_config_dir)
|
||||||
self.config_directory = self.config_directories.user_config_dir
|
|
||||||
|
|
||||||
self.download_directory.mkdir(exist_ok=True, parents=True)
|
self.download_directory.mkdir(exist_ok=True, parents=True)
|
||||||
self.logfile_directory.mkdir(exist_ok=True, parents=True)
|
self.config_directory.mkdir(exist_ok=True, parents=True)
|
||||||
|
|
||||||
def _load_config(self):
|
def _load_config(self):
|
||||||
self.cfg_parser = configparser.ConfigParser()
|
self.cfg_parser = configparser.ConfigParser()
|
||||||
|
@ -150,7 +149,7 @@ class RedditDownloader:
|
||||||
|
|
||||||
def _create_file_logger(self):
|
def _create_file_logger(self):
|
||||||
main_logger = logging.getLogger()
|
main_logger = logging.getLogger()
|
||||||
file_handler = logging.FileHandler(self.logfile_directory / 'log_output.txt')
|
file_handler = logging.FileHandler(Path(self.config_directory, 'log_output.txt'), mode='w')
|
||||||
formatter = logging.Formatter('[%(asctime)s - %(name)s - %(levelname)s] - %(message)s')
|
formatter = logging.Formatter('[%(asctime)s - %(name)s - %(levelname)s] - %(message)s')
|
||||||
file_handler.setFormatter(formatter)
|
file_handler.setFormatter(formatter)
|
||||||
file_handler.setLevel(0)
|
file_handler.setLevel(0)
|
||||||
|
|
|
@ -44,10 +44,7 @@ def assert_all_results_are_submissions(result_limit: int, results: list[Iterator
|
||||||
def test_determine_directories(tmp_path: Path, downloader_mock: MagicMock):
|
def test_determine_directories(tmp_path: Path, downloader_mock: MagicMock):
|
||||||
downloader_mock.args.directory = tmp_path / 'test'
|
downloader_mock.args.directory = tmp_path / 'test'
|
||||||
RedditDownloader._determine_directories(downloader_mock)
|
RedditDownloader._determine_directories(downloader_mock)
|
||||||
|
|
||||||
assert Path(tmp_path / 'test').exists()
|
assert Path(tmp_path / 'test').exists()
|
||||||
assert downloader_mock.logfile_directory == Path(tmp_path / 'test' / 'LOG_FILES')
|
|
||||||
assert downloader_mock.logfile_directory.exists()
|
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.parametrize(('skip_extensions', 'skip_domains'), (
|
@pytest.mark.parametrize(('skip_extensions', 'skip_domains'), (
|
||||||
|
|
Loading…
Reference in a new issue