From 1d95778b037308092f16ce0f814b3912e69df198 Mon Sep 17 00:00:00 2001 From: OMEGARAZER <869111+OMEGARAZER@users.noreply.github.com> Date: Mon, 5 Jun 2023 19:59:37 -0400 Subject: [PATCH] Connector test edge case Covers edge case of not having the exact amount as the limit, now allows between one and the limit. --- tests/test_connector.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/test_connector.py b/tests/test_connector.py index b4a7549..55ac6bf 100644 --- a/tests/test_connector.py +++ b/tests/test_connector.py @@ -3,6 +3,7 @@ from collections.abc import Iterator from datetime import datetime, timedelta from pathlib import Path +from typing import Union from unittest.mock import MagicMock import praw @@ -37,21 +38,23 @@ def downloader_mock(args: Configuration): return downloader_mock -def assert_all_results_are_submissions(result_limit: int, results: list[Iterator]) -> list: +def assert_all_results_are_submissions(result_limit: Union[int, None], results: list[Iterator]) -> list: results = [sub for res in results for sub in res] assert all([isinstance(res, praw.models.Submission) for res in results]) assert not any([isinstance(m, MagicMock) for m in results]) if result_limit is not None: - assert len(results) == result_limit + assert len(results) > 0 + assert len(results) <= result_limit return results -def assert_all_results_are_submissions_or_comments(result_limit: int, results: list[Iterator]) -> list: +def assert_all_results_are_submissions_or_comments(result_limit: Union[int, None], results: list[Iterator]) -> list: results = [sub for res in results for sub in res] assert all([isinstance(res, (praw.models.Submission, praw.models.Comment)) for res in results]) assert not any([isinstance(m, MagicMock) for m in results]) if result_limit is not None: - assert len(results) == result_limit + assert len(results) > 0 + assert len(results) <= result_limit return results