From df5a435696d65654c6e8505dc734509000a75d8c Mon Sep 17 00:00:00 2001 From: Peter Clement Date: Thu, 7 Mar 2024 09:27:31 +0000 Subject: [PATCH 1/3] Fix issue with being able to select one to one relationship --- .../backend/Datasources/CreateEditRelationship.svelte | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/builder/src/components/backend/Datasources/CreateEditRelationship.svelte b/packages/builder/src/components/backend/Datasources/CreateEditRelationship.svelte index 6b9524776c..b54ecbf9fd 100644 --- a/packages/builder/src/components/backend/Datasources/CreateEditRelationship.svelte +++ b/packages/builder/src/components/backend/Datasources/CreateEditRelationship.svelte @@ -40,8 +40,15 @@ part2: PrettyRelationshipDefinitions.MANY, }, } - let relationshipOpts1 = Object.values(PrettyRelationshipDefinitions) - let relationshipOpts2 = Object.values(PrettyRelationshipDefinitions) + $: relationshipOpts1 = + relationshipPart2 === PrettyRelationshipDefinitions.ONE + ? [PrettyRelationshipDefinitions.MANY] + : Object.values(PrettyRelationshipDefinitions) + + $: relationshipOpts2 = + relationshipPart1 === PrettyRelationshipDefinitions.ONE + ? [PrettyRelationshipDefinitions.MANY] + : Object.values(PrettyRelationshipDefinitions) let relationshipPart1 = PrettyRelationshipDefinitions.ONE let relationshipPart2 = PrettyRelationshipDefinitions.MANY From 4b84f5f1279ab93c080d1c2f10157ee66d2e3d31 Mon Sep 17 00:00:00 2001 From: Conor Webb <126772285+ConorWebb96@users.noreply.github.com> Date: Thu, 7 Mar 2024 10:54:10 +0000 Subject: [PATCH 2/3] Added custom title field to confirm actions modals (#13208) * Added custom title field to confirm actions modals * Changed label text to display Title/Text instead of having Confirm infront --- .../controls/ButtonActionEditor/actions/DeleteRow.svelte | 5 ++++- .../ButtonActionEditor/actions/DuplicateRow.svelte | 8 +++++++- .../ButtonActionEditor/actions/ExecuteQuery.svelte | 8 +++++++- .../controls/ButtonActionEditor/actions/SaveRow.svelte | 5 ++++- 4 files changed, 22 insertions(+), 4 deletions(-) diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/DeleteRow.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/DeleteRow.svelte index b8459ac0eb..431368d28f 100644 --- a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/DeleteRow.svelte +++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/DeleteRow.svelte @@ -45,7 +45,10 @@ {#if parameters.confirm} - + + + + {#if parameters.confirm} - + + + + + + diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/SaveRow.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/SaveRow.svelte index a1fe773455..d834e9aac9 100644 --- a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/SaveRow.svelte +++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/SaveRow.svelte @@ -72,7 +72,10 @@ {#if parameters.confirm} - + + + + Date: Thu, 7 Mar 2024 13:13:56 +0100 Subject: [PATCH 3/3] Remove logWarn --- packages/backend-core/src/cache/docWritethrough.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/backend-core/src/cache/docWritethrough.ts b/packages/backend-core/src/cache/docWritethrough.ts index de119572f2..f76bf0be78 100644 --- a/packages/backend-core/src/cache/docWritethrough.ts +++ b/packages/backend-core/src/cache/docWritethrough.ts @@ -2,7 +2,6 @@ import { AnyDocument, Database } from "@budibase/types" import { JobQueue, createQueue } from "../queue" import * as dbUtils from "../db" -import { logWarn } from "../logging" interface ProcessDocMessage { dbName: string @@ -27,9 +26,10 @@ class DocWritethroughProcessor { await this.persistToDb(message.data) } catch (err: any) { if (err.status === 409) { - logWarn(`409 conflict in doc-writethrough cache`) // If we get a 409, it means that another job updated it meanwhile. We want to retry it to persist it again. - throw new Error(`Conflict persisting message ${message.id}`) + throw new Error( + `Conflict persisting message ${message.id}. Attempt ${message.attemptsMade}` + ) } throw err