From fc44b38fc5e5a2cab4a920e4cf0aac6d6d855247 Mon Sep 17 00:00:00 2001
From: Sam Rose <hello@samwho.dev>
Date: Fri, 20 Sep 2024 11:52:06 +0100
Subject: [PATCH] Fix tests.

---
 .../server/src/api/routes/tests/viewV2.spec.ts   | 16 ++++++++--------
 packages/shared-core/src/helpers/views.ts        |  6 ------
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts
index 6769c80867..9313e3ab4d 100644
--- a/packages/server/src/api/routes/tests/viewV2.spec.ts
+++ b/packages/server/src/api/routes/tests/viewV2.spec.ts
@@ -37,13 +37,13 @@ import {
 import sdk from "../../../sdk"
 
 describe.each([
-  // ["lucene", undefined],
+  ["lucene", undefined],
   ["sqs", undefined],
-  // [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)],
-  // [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)],
-  // [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)],
-  // [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)],
-  // [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)],
+  [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)],
+  [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)],
+  [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)],
+  [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)],
+  [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)],
 ])("/v2/views (%s)", (name, dsProvider) => {
   const config = setup.getConfig()
   const isSqs = name === "sqs"
@@ -2295,7 +2295,7 @@ describe.each([
         )
       })
 
-      describe("calculations", () => {
+      describe.skip("calculations", () => {
         let table: Table
         let rows: Row[]
 
@@ -2325,7 +2325,7 @@ describe.each([
           )
         })
 
-        it.only("should be able to search by calculations", async () => {
+        it("should be able to search by calculations", async () => {
           const view = await config.api.viewV2.create({
             tableId: table._id!,
             name: generator.guid(),
diff --git a/packages/shared-core/src/helpers/views.ts b/packages/shared-core/src/helpers/views.ts
index 0364ccff41..c65bc4882d 100644
--- a/packages/shared-core/src/helpers/views.ts
+++ b/packages/shared-core/src/helpers/views.ts
@@ -25,15 +25,9 @@ export function isCalculationView(view: UnsavedViewV2) {
 }
 
 export function calculationFields(view: UnsavedViewV2) {
-  if (!isCalculationView(view)) {
-    throw new Error("View is not a calculation view")
-  }
   return pickBy(view.schema || {}, isCalculationField)
 }
 
 export function basicFields(view: UnsavedViewV2) {
-  if (!isCalculationView(view)) {
-    throw new Error("View is not a calculation view")
-  }
   return pickBy(view.schema || {}, field => !isCalculationField(field))
 }