1
0
Fork 0
mirror of synced 2024-07-05 22:40:39 +12:00

PR Feedback

This commit is contained in:
Dean 2023-11-10 12:02:11 +00:00
parent 39d899bcbc
commit f808b3e111
3 changed files with 2 additions and 15 deletions

View file

@ -91,7 +91,6 @@
open = true
}
}}
{disabled}
/>
<Popover

View file

@ -152,10 +152,6 @@
const parsedColumns = getValidColumns(columns, options)
dispatch("change", parsedColumns)
}
const toggleAll = update => {
listUpdated(update)
}
</script>
<div class="field-configuration">
@ -167,7 +163,7 @@
...field,
active: selectAll,
}))
toggleAll(update)
listUpdated(update)
}}
text=""
bind:value={selectAll}

View file

@ -11,7 +11,6 @@
export let componentBindings
export let bindings
export let anchor
export let updating //or disabled
const dispatch = createEventDispatcher()
const onToggle = item => {
@ -50,7 +49,6 @@
{bindings}
{parseSettings}
on:change
disabled={updating}
>
<div slot="header" class="type-icon">
<Icon name={componentDef.icon} />
@ -60,13 +58,7 @@
<div class="field-label">{readableText}</div>
</div>
<div class="list-item-right">
<Toggle
on:change={onToggle(item)}
text=""
value={item.active}
thin
disabled={updating}
/>
<Toggle on:change={onToggle(item)} text="" value={item.active} thin />
</div>
</div>