From e88ffea1a4262579bfdb7e1fcf6f0e179542bcd4 Mon Sep 17 00:00:00 2001 From: Gerard Burns Date: Tue, 18 Jun 2024 11:18:05 +0100 Subject: [PATCH] Modal component (#13848) * wip * wip * wip * wip * wip * add note for illegalChildren reset behavior * on close working * wip * lint * wip * Fix potential remounting loop caused by spreading props and unnecessary component keying * theme * user prompt * dotted border for empty * PR Feedback * lint * fix modal background color * use bbui modal * lint * fix indicator and prevent closing modal in builder * pr feedback * pr feedback * fix fullscreen --------- Co-authored-by: deanhannigan Co-authored-by: Andrew Kingston --- packages/bbui/src/Modal/Modal.svelte | 2 +- .../actions/CloseModal.svelte | 8 + .../actions/OpenModal.svelte | 36 +++++ .../ButtonActionEditor/actions/index.js | 2 + .../controls/ButtonActionEditor/manifest.json | 12 ++ .../new/_components/NewComponentPanel.svelte | 9 +- .../new/_components/componentStructure.json | 2 +- .../builder/src/stores/builder/screens.js | 9 +- packages/client/manifest.json | 49 +++++- .../client/src/components/ClientApp.svelte | 10 +- .../client/src/components/app/Layout.svelte | 3 + .../client/src/components/app/Link.svelte | 9 +- .../client/src/components/app/Modal.svelte | 141 ++++++++++++++++++ .../app/blocks/form/FormBlock.svelte | 63 ++++---- .../app/blocks/form/InnerFormBlock.svelte | 16 +- packages/client/src/components/app/index.js | 1 + .../components/preview/IndicatorSet.svelte | 5 +- packages/client/src/sdk.js | 2 + packages/client/src/stores/index.js | 1 + packages/client/src/stores/modal.js | 32 ++++ packages/client/src/utils/buttonActions.js | 14 ++ packages/frontend-core/src/utils/utils.js | 3 + 22 files changed, 376 insertions(+), 53 deletions(-) create mode 100644 packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/CloseModal.svelte create mode 100644 packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/OpenModal.svelte create mode 100644 packages/client/src/components/app/Modal.svelte create mode 100644 packages/client/src/stores/modal.js diff --git a/packages/bbui/src/Modal/Modal.svelte b/packages/bbui/src/Modal/Modal.svelte index 4656be69d1..dec1455d0c 100644 --- a/packages/bbui/src/Modal/Modal.svelte +++ b/packages/bbui/src/Modal/Modal.svelte @@ -162,6 +162,7 @@ max-height: 100%; } .modal-inner-wrapper { + padding: 40px; flex: 1 1 auto; display: flex; flex-direction: row; @@ -176,7 +177,6 @@ border: 2px solid var(--spectrum-global-color-gray-200); overflow: visible; max-height: none; - margin: 40px 0; transform: none; --spectrum-dialog-confirm-border-radius: var( --spectrum-global-dimension-size-100 diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/CloseModal.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/CloseModal.svelte new file mode 100644 index 0000000000..ed0ca2c72b --- /dev/null +++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/CloseModal.svelte @@ -0,0 +1,8 @@ +
This action doesn't require any settings.
+ + diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/OpenModal.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/OpenModal.svelte new file mode 100644 index 0000000000..8e61b8763f --- /dev/null +++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/OpenModal.svelte @@ -0,0 +1,36 @@ + + +
+ +